Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for static code analysis issues #3214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmetzger1000
Copy link

Mainly casts and a few other minor changes.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@acetcom acetcom added the type:wontfix Indicates that work won't continue on an issue, pull request, or discussion label May 17, 2024
@acetcom
Copy link
Member

acetcom commented May 17, 2024

@jmetzger1000

This pull request will not be merged for the reasons below.

  1. This pull request is canceling the action below.
    bba0ebe
    80ab4c4
    95de14c

  2. asn1c and ipfw are not source code maintained by open5gs.

  3. It's worth explaining in more detail how the following approach causes problems. I don't know if this is the correct way to do it in terms of operator precedence. It's better to describe it so that someone else can understand this without having to study it specifically, just from your description.

(typecast) 1 << variable

Sorry for this!
Sukchan

Copy link

As there has been no recent activity on this PR, it has been marked as stale. It will be automatically closed if no further action is taken.

@github-actions github-actions bot added the Stale label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale type:wontfix Indicates that work won't continue on an issue, pull request, or discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants