Open
Description
It should be noted that "nightly" is what is recommended by yt-dlp to use. Not stable, release, or main. Says so right in the README. ;)
If we want to keep using the older not-recommended version in ytdl-sub
releases, then there should be an easier procedure for end users to update to the Recommended version of yt-dlp
.
We could simply switch to nightly and be done. It wouldn't hurt existing users, and would satisfy this issue. Using the yt-dlp documented ways to try to update is broken:
$ yt-dlp --update-to nightly
Current version: stable@2024.12.23 from yt-dlp/yt-dlp
Latest version: nightly@2024.12.26.232815 from yt-dlp/yt-dlp-nightly-builds
ERROR: You installed yt-dlp with pip or using the wheel from PyPi; Use that to update
Currently, to update, one has to:
- set a SUDO password in the compose file (and the lookup for how to do that)
- use sudo/root to
pip uninstall
yt-dlp - and then
sudo pip install --pre yt-dlp
to get the nightly. And of course, this doesn't survive a container restart/rebuild/upgrade either.
...which yields an interesting ERROR below. however, it does seem to continue working.
abc@e35b3754346a:~/ytdl-sub-configs$ sudo pip install --pre yt-dlp
Collecting yt-dlp
Using cached yt_dlp-2024.12.26.232815.dev0-py3-none-any.whl (3.2 MB)
Installing collected packages: yt-dlp
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
ytdl-sub 2024.12.27.post1 requires yt-dlp[default]==2024.12.23, but you have yt-dlp 2024.12.26.232815.dev0 which is incompatible.
Successfully installed yt-dlp-2024.12.26.232815.dev0
WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
Activity
jmbannon commentedon Jan 10, 2025
This would be a great feature. I think a good approach would be to toggle it via ENV variable to enroll in nightly. That way, we could perform in the install on container start-up, and if things break (and they will using nightly), it'd be easy to simply set the flag back to false to go back to the stable version
GideonBear commentedon Jan 15, 2025
To add to this, I think it is a good idea regardless of channel (stable, nightly, master) to do
yt-dlp
updates within the container (automatically), without needing to wait for a new version ofytdl-sub
; I'm currently waiting on #1158 to fix an issue I have, which seems to be resolved in that update. Not to say you're too slow; but it's always faster to update it directly.