-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce new Etcd status condition AllMembersUpdated
#987
Merged
shreyas-s-rao
merged 3 commits into
gardener:master
from
shreyas-s-rao:enh/cond/members-updated
Feb 3, 2025
Merged
Introduce new Etcd status condition AllMembersUpdated
#987
shreyas-s-rao
merged 3 commits into
gardener:master
from
shreyas-s-rao:enh/cond/members-updated
Feb 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
unmarshall
requested changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Just a minor change. Rest of the PR looks good.
/retest |
unmarshall
approved these changes
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/control-plane
Control plane related
area/monitoring
Monitoring (including availability monitoring and alerting) related
area/ops-productivity
Operator productivity related (how to improve operations)
area/usability
Usability related
kind/api-change
API change with impact on API users
kind/enhancement
Enhancement, improvement, extension
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
needs/review
Needs review
needs/second-opinion
Needs second review by someone else
size/l
Size of pull request is large (see gardener-robot robot/bots/size.py)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area control-plane monitoring ops-productivity usability
/kind enhancement api-change
What this PR does / why we need it:
This PR introduces a new Etcd status condition
AllMembersUpdated
, to indicate whether all the underlying etcd member pods have been updated with the latest Etcd spec changes after reconciliation. This allows consumers of the Etcd status to know when a rollout of their spec changes has completed.Additionally, condition statuses
Progressing
andConditionCheckError
are now deprecated, and will soon be removed, since druid conditions will be replaced bymetav1.Condition
in the future.Also, a small change has been made to the etcd components webhook handler, to output the
druid.gardener.cloud/disable-etcd-component-protection
annotation when disallowing an operation on an etcd component managed by druid. This helps users avoid searching through the documentation for the specific annotation to add in order to disable the webhook check.Which issue(s) this PR fixes:
Fixes #985
Special notes for your reviewer:
/invite @unmarshall
/assign @unmarshall
/cc @timuthy
Release note: