Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new Etcd status condition AllMembersUpdated #987

Merged

Conversation

shreyas-s-rao
Copy link
Contributor

How to categorize this PR?

/area control-plane monitoring ops-productivity usability
/kind enhancement api-change

What this PR does / why we need it:
This PR introduces a new Etcd status condition AllMembersUpdated, to indicate whether all the underlying etcd member pods have been updated with the latest Etcd spec changes after reconciliation. This allows consumers of the Etcd status to know when a rollout of their spec changes has completed.

Additionally, condition statuses Progressing and ConditionCheckError are now deprecated, and will soon be removed, since druid conditions will be replaced by metav1.Condition in the future.

Also, a small change has been made to the etcd components webhook handler, to output the druid.gardener.cloud/disable-etcd-component-protection annotation when disallowing an operation on an etcd component managed by druid. This helps users avoid searching through the documentation for the specific annotation to add in order to disable the webhook check.

Which issue(s) this PR fixes:
Fixes #985

Special notes for your reviewer:
/invite @unmarshall
/assign @unmarshall
/cc @timuthy

Release note:

Introduce new Etcd status condition `AllMembersUpdated`.
Condition statuses `Progressing` and `ConditionCheckError` are now deprecated and will soon be removed, since druid conditions will be replaced by `metav1.Condition` in the future.

@shreyas-s-rao shreyas-s-rao added this to the v0.27.0 milestone Jan 29, 2025
@shreyas-s-rao shreyas-s-rao requested a review from a team as a code owner January 29, 2025 09:47
@gardener-robot gardener-robot added the needs/review Needs review label Jan 29, 2025
@gardener-robot gardener-robot added area/control-plane Control plane related area/monitoring Monitoring (including availability monitoring and alerting) related area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jan 29, 2025
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 29, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 29, 2025
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Just a minor change. Rest of the PR looks good.

internal/health/condition/check_all_members_updated.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 2, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2025
@unmarshall unmarshall self-requested a review February 3, 2025 04:17
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 3, 2025
@unmarshall
Copy link
Contributor

/retest

Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shreyas-s-rao shreyas-s-rao merged commit dd09e93 into gardener:master Feb 3, 2025
13 checks passed
@shreyas-s-rao shreyas-s-rao deleted the enh/cond/members-updated branch February 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related area/monitoring Monitoring (including availability monitoring and alerting) related area/ops-productivity Operator productivity related (how to improve operations) area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clients potentially miss etcd spec roll outs
5 participants