[Android] Fix Numeric Entry not accepting the appropriate Decimal Separator #27376
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 0ddc794.
…msLayout is set for Tablet but not on mobile devices (dotnet#26152)" This reverts commit 4b9074c.
|
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
sheiksyedm
added
the
partner/syncfusion
devanathan-vaithiyanathan
requested review from
StephaneDelcroix and
jfversluis
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Core/src/Platform/Android/LocalizedDigitsKeyListener.cs:26
- The new behavior introduced in GetDecimalSeparator should be covered by tests to ensure it handles different culture settings correctly.
string symbol = CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The previous behavior does not consider the application's current culture settings, causing the decimal separator to default.
Description of Change
Updated the GetDecimalSeparator method to retrieve the DecimalSeparator from the current culture using CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator, ensuring accurate and culture-specific formatting.
Regarding test case
I couldn't find a way to enter a comma using the numeric keyboard, so I didn't add the test case.
Issues Fixed
Fixes #17152
Tested the behavior in the following platforms.
Output Screenshot
Before_fix.mov
After_fix.mov