dompdf bin script for installing fonts #2777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkimsal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the Utils/load_font.php script and turned it into a script that would be available via composer bin scripts after install. To support the concept of installing fonts as packages, as mentioned in #1979, I would expect the base dompdf supplies dependent packages with a font install script that can be triggered on post-install.
This could work for any root project that requires dompdf and wants to install custom fonts into the correct location during a build pipeline or post installation.
The command
font:installwas put in place to support more future commands like "font:clear-cache" or "font:list-installed"