.github: Use --interactive=false more widely #37392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Jan 31, 2025
rolinh
approved these changes
Jan 31, 2025
brlbil
approved these changes
Jan 31, 2025
The 'cilium clustermesh status' command doesn't currently have an --interactive flag; the prior commit mistakenly configured it. Fixes: a29ba19 (".github: Set --interactive=false for cilium status") Signed-off-by: Joe Stringer <joe@cilium.io>
Commit a29ba19 (".github: Set --interactive=false for cilium status") began making use of the '--interactive' flag for 'cilium status --wait' commands in order to minimize duplicate status output and hence make CI failures easier to read & debug. Extend this approach to the remaining workflows. Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
pr/joe/cli-interactive-false-v2
branch
from
ad03bd2 to
4d19ee7
Compare
|
/test |
youngnick
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a29ba19 (".github: Set --interactive=false for cilium status")
began making use of the '--interactive=false' flag for 'cilium status --wait'
commands in order to minimize duplicate status output and hence make CI
failures easier to read & debug. Extend this approach to the remaining
workflows.