Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move the dind image to Quay to avoid rate-limiting #37388

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

pchaigno
Copy link
Member

Our CI sometimes fail with:

+[02:21:02] docker run --privileged --name lb-node -d --restart=on-failure:10 --network cilium-l4lb -v /lib/modules:/lib/modules docker:dind
Unable to find image 'docker:dind' locally
docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

This commit therefore switches those tests to start using our copy of the dind image, on our Quay account.

Our CI sometimes fail with:

    +[02:21:02] docker run --privileged --name lb-node -d --restart=on-failure:10 --network cilium-l4lb -v /lib/modules:/lib/modules docker:dind
    Unable to find image 'docker:dind' locally
    docker: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

This commit therefore switches those tests to start using our copy of
the dind image, on our Quay account.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno added the release-note/ci This PR makes changes to the CI. label Jan 31, 2025
@pchaigno
Copy link
Member Author

/test

@pchaigno pchaigno marked this pull request as ready for review January 31, 2025 12:30
@pchaigno pchaigno requested review from a team as code owners January 31, 2025 12:30
@pchaigno pchaigno enabled auto-merge January 31, 2025 12:30
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Should we backport this as well, to avoid the same issue in CI for stable branches?

@pchaigno pchaigno added needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Jan 31, 2025
@pchaigno pchaigno removed the request for review from ysksuzuki January 31, 2025 12:56
@pchaigno pchaigno added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 25c82e7 Jan 31, 2025
151 checks passed
@pchaigno pchaigno deleted the pr/pchaigno/switch-dind-to-quay branch January 31, 2025 13:16
@tklauser tklauser mentioned this pull request Feb 5, 2025
3 tasks
@tklauser tklauser added backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. and removed needs-backport/1.17 This PR / issue needs backporting to the v1.17 branch labels Feb 5, 2025
@tklauser tklauser mentioned this pull request Feb 5, 2025
2 tasks
@tklauser tklauser added backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. and removed needs-backport/1.16 This PR / issue needs backporting to the v1.16 branch labels Feb 5, 2025
@tklauser tklauser mentioned this pull request Feb 5, 2025
1 task
@tklauser tklauser added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 5, 2025
@github-actions github-actions bot added backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. and removed backport-pending/1.17 The backport for Cilium 1.17.x for this PR is in progress. backport-pending/1.16 The backport for Cilium 1.16.x for this PR is in progress. labels Feb 5, 2025
@github-actions github-actions bot added backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. backport-done/1.16 The backport for Cilium 1.16.x for this PR is done. backport-done/1.17 The backport for Cilium 1.17.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants