operator: Explicitly init the FQDN regex LRU cache #37366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christarazi
added
kind/bug
christarazi
force-pushed
the
pr/christarazi/init-fqdn-re-operation
branch
from
a9ed50e to
41c83f8
Compare
christarazi
added
the
needs-backport/1.17
This comment was marked as outdated.
This comment was marked as outdated.
In cilium#37355, it is possible that the LRU is not initialized at the time of the policy validation logic. Fix this by explicitly calling InitRegexCompileLRU() in the policy validator cell. FWIW, during my attempt to locally reproduce, I was not able to. Inspecting the stacktrace [1] when InitRegexCompileLRU() was called which I obtained by adding debug statements reveals that the cache is initialized via `init()` of the cilium-dbg package. I'm not sure why there is a mismatch between what I observed and the aforementioned report, but regardless, it is worth adding an explicit call to InitRegexCompileLRU() in case the `init()` is no longer called in the future. [1]: ``` goroutine 1 [running, locked to thread]: runtime/debug.Stack() /usr/local/go/src/runtime/debug/stack.go:26 +0x5e github.com/cilium/cilium/pkg/fqdn/re.InitRegexCompileLRU(0x1) /go/src/github.com/cilium/cilium/pkg/fqdn/re/re.go:57 +0x73 github.com/cilium/cilium/cilium-dbg/cmd.init.119() /go/src/github.com/cilium/cilium/cilium-dbg/cmd/policy.go:47 +0x46 ``` Fixes: cilium#37355 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/init-fqdn-re-operation
branch
from
41c83f8 to
cece3d5
Compare
|
/test |
derailed
approved these changes
Feb 3, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
22 tasks
nbusseneau
added
backport-pending/1.17
github-actions
bot
added
backport-done/1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37355, it is possible that
the LRU is not initialized at the time of the policy validation logic.
Fix this by explicitly calling InitRegexCompileLRU() in the policy
validator cell.
FWIW, during my attempt to locally reproduce, I was not able to.
Inspecting the stacktrace [1] when InitRegexCompileLRU() was called which I
obtained by adding debug statements reveals that the cache is
initialized via
init()of the cilium-dbg package. I'm not sure whythere is a mismatch between what I observed and the aforementioned
report, but regardless, it is worth adding an explicit call to
InitRegexCompileLRU() in case the
init()is no longer called in thefuture.
[1]:
Fixes: #37355
Signed-off-by: Chris Tarazi chris@isovalent.com