envoy: skip secret sync registration if l7-proxy is disabled #37348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, having L7 proxy functionality disabled (`--enable-l7-proxy=false`) might lead to issues / panics when syncing secrets to Envoy fails due to the xdsServer (its mutators) not being fully initialized. Therefore, this commit is adding an additional config that checks that L7 proxy is enabled before registering the secret syncs. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
area/proxy
|
/test |
mhofstetter
changed the title
giorio94
added
the
needs-backport/1.17
maintainer-s-little-helper
bot
added
the
ready-to-merge
mhofstetter
deleted the
pr/mhofstetter/disable-agent-secretsync-if-l7proxy-disabled
branch
giorio94
added
backport-pending/1.17
github-actions
bot
added
backport-done/1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, having L7 proxy functionality disabled (
--enable-l7-proxy=false) might lead to issues / panics when syncing secrets to Envoy fails due to the xdsServer (its mutators) not being fully initialized.Therefore, this commit is adding an additionl config that checks that L7 proxy is enabled before registering the secret syncs.