cilium-dbg/troubleshoot: do not import cilium-dbg from operator #37326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
added
release-note/misc
|
/test |
aanm
force-pushed
the
pr/fix-troubleshooting-concurrency
branch
from
8efa608 to
ece4894
Compare
|
/test |
giorio94
approved these changes
Jan 29, 2025
Since we are importing cilium-dbg from the operator, this is causing all of its init() functions to be initialized causing some potential concurrency issues as cilium-dbg is initializing functions assuming it's the only binary using them, same as with the operator. To avoid this problem, we will move the troubleshoot as an independent package that can be imported by the operator, the clustermesh-apiserver and the cilium-dbg tool. Fixes: 5f0e3e2 ("operator: add troubleshoot subcommands") Signed-off-by: André Martins <andre@cilium.io>
aanm
force-pushed
the
pr/fix-troubleshooting-concurrency
branch
from
ece4894 to
6625571
Compare
|
/test |
dlapcevic
approved these changes
Jan 29, 2025
asauber
approved these changes
Jan 29, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
backport-pending/1.17
giorio94
added
backport-pending/1.16
github-actions
bot
added
backport-done/1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are importing cilium-dbg from the operator, this is causing all of its init() functions to be initialized causing some potential concurrency issues as cilium-dbg is initializing functions assuming it's the only binary using them, same as with the operator. To avoid this problem, we will move the troubleshoot as an independent package that can be imported by the operator, the clustermesh-apiserver and the cilium-dbg tool.
Fixes: 5f0e3e2 ("operator: add troubleshoot subcommands")