Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble-relay: remove deprecated dial-timeout flag #37314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

hubble-relay: remove deprecated dial-timeout flag #37314

wants to merge 1 commit into from

Conversation

devodev
Copy link
Contributor

@devodev devodev commented Jan 28, 2025 •
edited
Loading

Follow-up to: #36027 where we deprecated the --dial-timeout flag in hubble-relay. This removes the flag and helm option, as well as update the upgrade guide.

Fixes: #36240

@devodev devodev requested review from a team as code owners January 28, 2025 20:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 28, 2025
@devodev devodev requested a review from qmonnet January 28, 2025 20:55
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 28, 2025
qmonnet
qmonnet approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option is deprecated in v1.17 already, right? If that's the case then all good, tanks!

@qmonnet
Copy link
Member

qmonnet commented Jan 29, 2025

/test

@qmonnet qmonnet added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. upgrade-impact This PR has potential upgrade or downgrade impact. sig/hubble Impacts hubble server or relay labels Jan 29, 2025
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 29, 2025
@devodev
Copy link
Contributor Author

devodev commented Jan 29, 2025

The option is deprecated in v1.17 already, right? If that's the case then all good, tanks!

Yes exactly!

@devodev devodev force-pushed the pr/devodev/remove-deprecated-dial-timeout-option branch from fecd941 to 4b2f3d9 Compare January 30, 2025 14:44
rolinh
rolinh approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@squeed
Copy link
Contributor

squeed commented Jan 31, 2025

Looks like the github outage got CI in a confused state. Might be easier just to rebase and force-push.

@devodev
hubble-relay: remove deprecated dial-timeout flag
622f724 
Signed-off-by: Alexandre Barone <abalexandrebarone@gmail.com>
@devodev devodev force-pushed the pr/devodev/remove-deprecated-dial-timeout-option branch from 4b2f3d9 to 622f724 Compare January 31, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@rolinh rolinh rolinh approved these changes

@youngnick youngnick youngnick approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay upgrade-impact This PR has potential upgrade or downgrade impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hubble-relay: remove dial-timeout following deprecation in 1.17
5 participants
@devodev @qmonnet @squeed @rolinh @youngnick