-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use runtime image set by env var action #37253
Merged
Merged
+33
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bba4337
to
2ada804
Compare
2ada804
to
48796db
Compare
nebril
approved these changes
Jan 24, 2025
aanm
approved these changes
Jan 28, 2025
48796db
to
56d0709
Compare
This commit : 1. Replace CILIUM_RUNTIME_IMAGE variable set in cilium images (cf. Dockerfiles) with the cilium-runtime image variable set in set-env-var action. 2. Changes the sed commands present in images/runtime/update-cilium-runtime-images.sh : - Changing the way the image variable is set inside the script. Before that the image was a constant, now it will be extracted from the image_full variable passed as parameter of the script. - For Dockerfile, it will not check what is prefixed and will update the image based on its name, so if any changes are name for any reason on prefixed image name on Dockerfiles this won't disrupt the image tag/digest update. example : if CILIUM_RUNTIME_IMAGE=quay.io/cilium/cilium-runtime:tag@digest is changed for RUNTIME_IMAGE=quay.io/cilium/cilium-runtime:tag@digest (or any other name) this won't affect the update process - For workflows, since the runtime image has been moved to an action (set-env-var), we now look on the .github/actions directory. Also added a double quote character to be sure no templating issue will be encountered when updating the set-env action. 3. Changes images/scripts/update-cilium-runtime-images.sh, used to lint cilium runtime images in CI, by removing the image name from a constant variable to a parameter passed along the call of the script. We are keeping quay.io/cilium/cilium-runtime as default parameter in the makefile, if nothing is provided to the script/target. But we allow ourselves the possibility to override this variable. This will allow us to change the repository of the runtime image without having to change the whole image build/lint process. Signed-off-by: Antony Reynaud <antony.reynaud@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
56d0709
to
3cf777f
Compare
/test |
@christarazi @kaworu kind ping |
christarazi
approved these changes
Jan 30, 2025
kaworu
approved these changes
Jan 30, 2025
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-done/1.17
The backport for Cilium 1.17.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit
This will allow us to change the repository of the runtime image without having to change the whole image build/lint process.
Follow-up of 8cc07d9