k8s: Convert from Resource[Pod] to Table[LocalPod] #36101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
2 times, most recently
from
fed2d41 to
cd15e5f
Compare
|
/test |
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
from
cd15e5f to
99557d3
Compare
|
/test |
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
from
99557d3 to
10ec1bd
Compare
joamaki
commented
Dec 4, 2024
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
from
10ec1bd to
d5531f5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
joamaki
removed
the
stale
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
from
d5531f5 to
c1616fb
Compare
|
/test |
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
3 times, most recently
from
2b1ff8a to
2cc303d
Compare
|
/test |
dylandreimerink
approved these changes
Jan 23, 2025
pippolo84
reviewed
Jan 23, 2025
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
from
2cc303d to
f5407d8
Compare
|
/test |
|
ping @youngnick @sayboras |
sayboras
approved these changes
Jan 27, 2025
Signed-off-by: Jussi Maki <jussi@isovalent.com>
As the first conversion of Resource[T] to Table[T], refactor Resource[Pod] into Table[LocalPod]. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/pod-table
branch
from
f5407d8 to
9d55fe7
Compare
|
/test |
youngnick
approved these changes
Jan 28, 2025
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
reviewed
Jan 28, 2025
Comment on lines
+30
to
+33
| time.Now = func() time.Time { | ||
| return time.Date(2000, 1, 1, 10, 30, 0, 0, time.UTC) | ||
| } | ||
| os.Setenv("TZ", "") |
There was a problem hiding this comment.
These should probably be restored after the test finishes, so they don't influence any successive tests:
now := time.Now
time.Now = func() time.Time {
return time.Date(2000, 1, 1, 10, 30, 0, 0, time.UTC)
}
t.Cleanup(func() { time.Now = now })
t.Setenv("TZ", "")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kicks off the transition away from
Resource[T]toTable[T]by switchingResource[*Pod]intoTable[LocalPod]. I've talked about the benefits in #34060. Thedaemon/k8s/testdata/pod.txtarsomewhat show-cases the benefits to inspection, testing and indexing. By storing the K8s objects in StateDB tables we get all the machinery for querying, watching for changes, testing (with 'db' script commands) and inspecting with cilium-dbg.I'm starting with pods as that's needed for #35652.
I'm not making
Table[LocalPod]aOnDemand[Table[LocalPod]], e.g. we'll start reflecting pods regardless of whether there's users for it or not, since it's one of the fundamental core k8s objects that we always pull regardless of configuration.For other conversions we'll need to consider carefully whether or not to start the reflection, or whether to expose the table as the reference counted
OnDemandresource.