Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2) fix keyboard enhancements msg, expose types and track requested and active enhancements #1286

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

aymanbagabas
Copy link
Member

@aymanbagabas aymanbagabas commented Jan 9, 2025

refactor: keyboard: expose type and track requested and active enhancements

This change exposes the KeyboardEnhancements type and tracks requested
and active enhancements in the Program struct. This change also
renames the KeyboardEnhancement type to KeyboardEnhancementOption
as well asEnableKeyboardEnhancements to RequestKeyboardEnhancements.

Fixes: #1283

Without this, keyboard enhancements events won't be sent to update
…ements

This change exposes the `KeyboardEnhancements` type and tracks requested
and active enhancements in the `Program` struct. This change also
renames the `KeyboardEnhancement` type to `KeyboardEnhancementOption`
and `keyboardEnhancements` to `KeyboardEnhancements` as well as
`EnableKeyboardEnhancements` to `RequestKeyboardEnhancements`.
@aymanbagabas aymanbagabas merged commit 4ed9c0a into v2-exp Jan 16, 2025
44 checks passed
@aymanbagabas aymanbagabas deleted the v2-enh-keeb branch January 16, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants