announcement bar creation #7948
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here are some screenshots of FE:
|
|
I have looked into this PR and need more time to think whether the current design is good. I agree that the feature makes sense. |
|
Relates to #5091 |
…*.txt file from specified folder c['messageInfoDir']. FE will shows all those messages.
mifo123
force-pushed
the
annoucment_bar
branch
from
eb5577c to
849b7d2
Compare
|
Hi @p12tic, did you have time to look at this? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add announcement bar with new endpoint '/messagesinfo' which will take *.txt file from specified folder c['messageInfoDir']. FE will shows all those messages.
Is this approach ok, or it should be done via some DB or any other way?
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)