Active Directory workaround #6559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tardyp
requested changes
Jul 27, 2022
| if len(res) > 1: | ||
| for elem in res: | ||
| if elem['type'] == 'searchResEntry': | ||
| tmp.append(elem) |
There was a problem hiding this comment.
do you mean to do res = tmp after the loop?
There was a problem hiding this comment.
Right , seems I was too sloppy when making the patch. Will Fix.
There was a problem hiding this comment.
Well, now the missing line is... below our conversation and easy to miss... Sorry for that.
|
Will add a unit test later (perhaps over the weekend). Do you have a pointer to an existing test which runs against a dummy LDAP instance or something like that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to connect a buildbot instance to an Active Directory and I needed a workaround to get it done, which I'd like to share. The problem is caused by Active Directory returning additional search result references which can not be suppressed by query parameters (e.g. https://superuser.com/questions/1438270/why-does-ad-return-searchresref-ldap-references-for-every-ldap-search). This leads to an exception when doing the user lookup.
I am sure that there are more elegant ways to filter out the unwanted search references than I did ;-) The unit tests ran fine without any changes before and after my change.
newsfragmentsdirectory (and read theREADME.txtin that directory)