Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DockerLatentWorker: Handle not found exception when stopping #5308

Closed
wants to merge 3 commits into from
Closed

DockerLatentWorker: Handle not found exception when stopping #5308

wants to merge 3 commits into from

Conversation

cmouse
Copy link
Contributor

@cmouse cmouse commented May 22, 2020 •
edited
Loading

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

If there is e.g. connectivity problem to the docker host, ensure we handle exceptions when stopping worker, otherwise the substantiation gets stuck on preparing worker.

tardyp
tardyp requested changes May 22, 2020
View reviewed changes
master/buildbot/worker/docker.py Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jul 25, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stalled label Jul 25, 2020
@cmouse
Copy link
Contributor Author

cmouse commented Jul 25, 2020

I'll look into this in few weeks.

@stale stale bot removed the stalled label Jul 25, 2020
@cmouse cmouse changed the title DockerLatentWorker: Handle exceptions better when stopping DockerLatentWorker: Handle not found exception when stopping Nov 24, 2020
@cmouse
Copy link
Contributor Author

cmouse commented Nov 24, 2020

Updated to catch the exception that's actually causing the problems.

@cmouse cmouse requested a review from tardyp November 24, 2020 08:05
@codecov
Copy link

codecov bot commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #5308 (7ad38db) into master (f5df7b0) will decrease coverage by 0.16%.
The diff coverage is 40.00%.

❗ Current head 7ad38db differs from pull request most recent head ce4af77. Consider uploading reports for the commit ce4af77 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
- Coverage   91.82%   91.66%   -0.17%     
==========================================
  Files         340      340              
  Lines       36371    36375       +4     
==========================================
- Hits        33398    33342      -56     
- Misses       2973     3033      +60
Impacted Files Coverage Δ
master/buildbot/worker/docker.py 82.66% <40.00%> (-0.60%) ⬇️
master/buildbot/__init__.py 76.92% <0.00%> (-15.39%) ⬇️
worker/buildbot_worker/__init__.py 77.61% <0.00%> (-14.93%) ⬇️
.../migrate/versions/048_change_properties_to_text.py 87.50% <0.00%> (-12.50%) ⬇️
...migrate/versions/046_mysql_innodb_compatibility.py 89.47% <0.00%> (-10.53%) ⬇️
master/buildbot/db/test_results.py 89.54% <0.00%> (-6.54%) ⬇️
master/buildbot/db/enginestrategy.py 69.17% <0.00%> (-5.48%) ⬇️
...dbot/db/migrate/versions/052_cascading_set_null.py 94.00% <0.00%> (-4.00%) ⬇️
master/buildbot/process/botmaster.py 94.64% <0.00%> (-3.58%) ⬇️
master/buildbot/db/connector.py 96.51% <0.00%> (-3.49%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5df7b0...ce4af77. Read the comment docs.

@cmouse
Copy link
Contributor Author

cmouse commented Apr 8, 2021

@tardyp @p12tic something I should do this to this?

@p12tic
Copy link
Member

p12tic commented Apr 24, 2021

@cmouse Sorry for missing this PR. It looks good to me in principle. Could we add tests to cover this new behaviour? There's already a number of tests in test_docker.py, it shouldn't be complex to extend that.

@mokibit mokibit self-assigned this Jan 10, 2025
@mokibit
Copy link
Collaborator

mokibit commented Jan 20, 2025

Fixed in #8303.

@p12tic p12tic closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p12tic p12tic p12tic left review comments

@tardyp tardyp Awaiting requested review from tardyp

Assignees

@mokibit mokibit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmouse @p12tic @mokibit @tardyp