Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions to find_library_load_path in docstrings #1032

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kwentine
Copy link
Contributor

@kwentine kwentine commented Nov 30, 2024

Hi. Thanks for great software and documentation.

Perusing library code I found some docstring mentions to no-longer-existing function find_library_load_path (removed in 4977720) This is a proposal to edit them away.

@kwentine kwentine requested a review from a team as a code owner November 30, 2024 13:14
Copy link
Member

@martin-schulze-vireso martin-schulze-vireso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your suggestions. LGTM.

Can you please add a changelog entry in the unreleased->documentation section for this?

@kwentine kwentine force-pushed the remove-find-library-load-path-mentions branch from 3818913 to 681d2d8 Compare January 13, 2025 13:43
@kwentine kwentine force-pushed the remove-find-library-load-path-mentions branch from 681d2d8 to f4c22be Compare January 13, 2025 13:47
@kwentine
Copy link
Contributor Author

Updated the CHANGELOG ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants