Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSPS7: Channel lease extensions #2720

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Jan 9, 2025

Description

Channel lease extensions

bLIP: https://github.com/lightning/blips/pull/57/files

LSPS7 deployed to:

  • Olympus Mainnet
  • Olympus Testnet3
  • Olympus Mutinynet

TODO:

  • Refactor existing LSP code
  • Wire up lsps7.get_extendable_channels
  • Wire up lsps7.create_order
  • Wire up lsps7.get_order
  • Channels list view
  • Single channel view
  • Create order flow
  • Order history
  • Update LND to accept LSP custom messages without extra build tags

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.10.0 milestone Jan 9, 2025
@kaloudis kaloudis changed the title LSPS7 LSPS7: Channel lease extensions Jan 9, 2025
@kaloudis kaloudis force-pushed the lsps7 branch 4 times, most recently from 6f11515 to 5bf3b51 Compare January 14, 2025 04:54
@kaloudis
Copy link
Contributor Author

For having remote LND users leverage LSPS0 custom messages (type 37913), we could potentially point them to this config flag: lightningnetwork/lnd@e8196c6#diff-3a6efa92418cc425498701df4dbd84e1d143908b58b9872f566a952baa281200R1316

@kaloudis kaloudis marked this pull request as ready for review January 14, 2025 06:12
@kaloudis kaloudis requested a review from shubhamkmr04 January 14, 2025 06:17
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 16 Plus - 2025-01-14 at 18 07 00
nit: diff in top and bottom margin of input box

@kaloudis kaloudis force-pushed the lsps7 branch 4 times, most recently from 198f5e6 to 72f5cc2 Compare January 17, 2025 18:16
@kaloudis kaloudis requested a review from shubhamkmr04 January 18, 2025 04:05
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 16 Pro Max - 2025-01-20 at 18 05 23
Can't open the single channel view

@kaloudis
Copy link
Contributor Author

kaloudis commented Jan 20, 2025

Can't open the single channel view

Which backend are you using?

@shubhamkmr04
Copy link
Contributor

Can't open the single channel view

Which backend are you using?

CLNRest

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulator Screenshot - iPhone 16 Pro Max - 2025-01-20 at 21 04 04
did we remove loading from LSPS1 view ?

@kaloudis kaloudis requested a review from shubhamkmr04 January 21, 2025 01:42
@kaloudis
Copy link
Contributor Author

Can't open the single channel view

Which backend are you using?

CLNRest

Good catch. This has been fixed.

@kaloudis
Copy link
Contributor Author

did we remove loading from LSPS1 view ?

There was some refactoring done to separate LSPS1 loading from LSPS7. Will review.

Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to see saved orders in OrdersPane view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants