Handle error when trying to save URL

Relequestual · Jan 3, 2020 · 821d295 · 821d295
1 parent 31479b8
commit 821d295
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 5 deletions.
diff --git a/src/App.vue b/src/App.vue
@@ -5,6 +5,7 @@
         <save-button
           :schema="primarySchemaText"
           :instance="instanceText"
+          @error="handleError"
         />
       </template>
     </navigation>
@@ -19,7 +20,7 @@
 
       <b-row v-if="errorMessage !== null" align-h="center">
         <b-col>
-          <b-alert variant="danger" show dismissible>
+          <b-alert variant="danger" show dismissible @dismissed="clearError">
             {{ errorMessage }}
           </b-alert>
         </b-col>
@@ -311,6 +312,12 @@ export default {
     updateEditorTheme: function(theme) {
       Vue.set(this, 'editorTheme', theme);
     },
+    handleError: function (error) {
+      Vue.set(this, 'errorMessage', error);
+    },
+    clearError: function() {
+      Vue.set(this, 'errorMessage', null);
+    }
   },
 };
 </script>

diff --git a/src/components/SaveButton.vue b/src/components/SaveButton.vue
@@ -71,10 +71,15 @@ export default {
   methods: {
     saveURLClick: async function() {
       Vue.set(this, 'saving', true);
-      const url = await shorter.genSaveURL({ sharedSchema: this.schema, sharedInstance: this.instance});
-      const shortURL = await shorter.shortenURL(url);
-      this.$router.replace(`/s/${shortURL}`);
-      Vue.set(this, 'saved', true);
+      try{
+        const url = await shorter.genSaveURL({ sharedSchema: this.schema, sharedInstance: this.instance});
+        const shortURL = await shorter.shortenURL(url);
+        this.$router.replace(`/s/${shortURL}`);
+        Vue.set(this, 'saved', true);
+      } catch(e) {
+        this.resetData();
+        this.$emit('error', e.message);
+      }
     },
     resetData: function (){
       const data = initialData();

diff --git a/src/utilities/shortner.js b/src/utilities/shortner.js
@@ -33,6 +33,9 @@ const shortenURL = async (url) => {
   }
 
   const result = await shorten(url);
+  if(result.status === 'fail') {
+    throw new Error(`Unable to save URL  - ${result.message}`);
+  }
   return result.url.keyword;
 }