-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vendor-junit4): initial junit4 version #577
Draft
Malinskiy
wants to merge
25
commits into
develop
Choose a base branch
from
feat/vendor-junit4
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gRPC gRPC may not be such a good idea after all: large library footprint + initialisation time cost If the booter is long-running this wouldn't be an issue though
tested with adam's tests
separate multi-module bundles quick fix for report path length use classloader switch for handling test parsing add debug booter flag
# Conflicts: # buildSrc/src/main/kotlin/Versions.kt # cli/src/test/kotlin/com/malinskiy/marathon/cli/config/ConfigFactoryTest.kt # core/src/main/kotlin/com/malinskiy/marathon/extension/StringExtensions.kt # core/src/main/kotlin/com/malinskiy/marathon/io/FileManager.kt
Core: - queue should print list of currently active tests when closing prematurely - impose file path limit of 255 characters instead of file name limit of 256 - file names should escape special characters (except . and #) - html report should handle long file names JUnit4: - enhance junit4 configuration: add parallelism, forkEvery, javaHome, javaOptions and useArgfiles - write junit4 device log files to investigate device failure under debug mode - junit4 booter should switch classloader instead of inheriting the classpath from booter (doesn't scale to multiple modules) - increase gRPC message limit to 32M (need to rework the api to streaming) - don't save empty logs - handle Ignore annotation (actual execution is messed up and doesn't fire proper events)
… classpath - booter startup retries - shadow runner classes
# Conflicts: # buildSrc/src/main/kotlin/Versions.kt # core/src/main/kotlin/com/malinskiy/marathon/execution/queue/QueueActor.kt # core/src/main/kotlin/com/malinskiy/marathon/extension/StringExtensions.kt # core/src/main/kotlin/com/malinskiy/marathon/io/FileManager.kt # core/src/main/kotlin/com/malinskiy/marathon/report/html/HtmlSummaryReporter.kt # core/src/test/kotlin/com/malinskiy/marathon/io/FileManagerTest.kt # html-report/src/components/Pool.js
- Inherited tests - Abstract parent test class - Java options verification Allow configuration of test execution mode in booter from marathon configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.