Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compute): delete region 'all' in generate_wrapped_rsa_key.py #13052

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal: b/389690705

Follow-up of b/280881053 & #10118

Checklist

@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Jan 13, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed:

This pull request, chore(compute): delete region 'all' in generate_wrapped_rsa_key.py, aims to remove the redundant # [START all] and # [END all] markers from the generate_wrapped_rsa_key.py file. This is a follow-up to previous work (b/280881053 and #10118) addressing issue b/389690705.

Here's a breakdown of the changes:

  • File: compute/encryption/generate_wrapped_rsa_key.py
    • Removed lines 22 and 122, which contained # [START all] and # [END all] respectively.
    • This is evident in the diff, showing the removal of these lines from the file. Before the change, lines 22 and 122 were:
22: # [START all]
122: # [END all]
* After the change, these lines are no longer present.

The author has confirmed that all linting checks passed and followed the sample guidelines.


And now, a little haiku to lighten the mood:

Code flows like a stream,
Markers removed, clean and bright,
Review's swift and calm.

Copy link

Gemini encountered an error creating the review. You can try again by commenting @code-review-assist review.

@eapl-gemugami
Copy link
Contributor Author

Note to reviewer: Please ignore the Python 3.13 failing check, as discussed with @davidcavazos in Cloud Samples Discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant