Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency google-cloud-datastore to v2.20.2 #13026

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
google-cloud-datastore ==2.20.1 -> ==2.20.2 age adoption passing confidence

Release Notes

googleapis/python-datastore (google-cloud-datastore)

v2.20.2

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - "* * 1 */3 *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested review from a team as code owners January 1, 2025 02:16
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 1, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files in the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: The primary goal is to keep the project's dependencies up-to-date, leveraging the latest bug fixes and improvements included in version 2.20.2 of the google-cloud-datastore library. The release notes mention a single bug fix related to preserving list meanings.
  • Changes: The version number for google-cloud-datastore has been updated in the following files:
    • appengine/flexible/datastore/requirements.txt
    • appengine/flexible_python37_and_earlier/datastore/requirements.txt
    • blog/introduction_to_data_models_in_cloud_datastore/requirements.txt
    • datastore/cloud-client/requirements.txt
    • dlp/snippets/requirements.txt
    • functions/v2/datastore/hello-datastore/requirements.txt

The changes are straightforward and consist solely of updating the version number in the requirements.txt files. No functional code changes are involved.

Here's a little something to brighten your day:

Small change, it's true,
But keeps our code fresh and new,
A minor update.

Let me know if you have any questions. I'll post my full review shortly.

Best,
Gemini

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. api: cloudfunctions Issues related to the Cloud Run functions API. api: datastore Issues related to the Datastore API. api: dlp Issues related to the Sensitive Data Protection API. labels Jan 1, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 1, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple services. The release notes indicate a bug fix related to preserving list meanings. It's good practice to keep dependencies up-to-date, so this change is positive. I've summarized the key change below.

Key Change in google-cloud-datastore 2.20.2:

  • Bug Fix: Preserves list meanings, addressing a potential issue where list semantics were not maintained during certain operations.

Given the automated nature of this PR and the targeted bug fix, the risk appears low. However, thorough testing is crucial after merging, especially for applications heavily reliant on the google-cloud-datastore library. I did not see a style guide provided, so I'm defaulting to PEP 8 style guide for Python (https://peps.python.org/pep-0008/). I've added some specific testing recommendations in the file-specific comments below.

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). Test thoroughly after merging, focusing on list operations within the Datastore context. Add a unit test to main_test.py replicating the original bug scenario (https://redirect.github.com/googleapis/python-datastore/issues/575) to prevent regressions.

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). Test thoroughly after merging, focusing on list operations within the Datastore context. Add a unit test to main_test.py replicating the original bug scenario (https://redirect.github.com/googleapis/python-datastore/issues/575) to prevent regressions.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). Ensure the blog post examples and the associated tests in blog_test.py and wiki_test.py are updated and tested to reflect the dependency change.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). Run all tests in snippets_test.py, admin_test.py, tasks_test.py, query_filter_or_test.py, and query_multi_ineq_test.py to ensure the core datastore functionality remains unaffected. Pay close attention to tests involving list operations.

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). While this update is likely unrelated to DLP functionality, it's still good practice to run the DLP tests after merging to ensure no unforeseen issues arise.

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended, per the PEP 8 style guide recommendation to keep dependencies up to date (https://peps.python.org/pep-0008/#id47). The bug fix in this release is relevant to Datastore functions, so ensure the tests in main_test.py cover the scenario described in the bug report (https://redirect.github.com/googleapis/python-datastore/issues/575).

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback in a few minutes. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files in the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: The primary goal is to keep the project's dependencies up-to-date, leveraging the latest bug fixes and improvements included in version 2.20.2 of the google-cloud-datastore library. The release notes mention a single bug fix related to preserving list meanings (Issue Flaky transaction snippets #575 in the googleapis/python-datastore repository).

  • Changes: The update affects the following files:

File Change
appengine/flexible/datastore/requirements.txt google-cloud-datastore==2.20.1 -> 2.20.2
appengine/flexible_python37_and_earlier/datastore/requirements.txt google-cloud-datastore==2.20.1 -> 2.20.2
blog/introduction_to_data_models_in_cloud_datastore/requirements.txt google-cloud-datastore==2.20.1 -> 2.20.2
datastore/cloud-client/requirements.txt google-cloud-datastore==2.20.1 -> 2.20.2
dlp/snippets/requirements.txt google-cloud-datastore==2.20.1 -> 2.20.2
functions/v2/datastore/hello-datastore/requirements.txt google-cloud-datastore==2.20.1 -> 2.20.2

Each change simply updates the version number in the respective requirements.txt file. No code logic changes are involved.

Here's a little poem to lighten the mood:

A minor bump, a version new,
Dependencies, fresh and true.
The code compiles, all is well,
Another PR, success to tell!

Let me know if you have any questions.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple services. This is a good practice to keep dependencies up-to-date. The included change log references a bug fix regarding list meanings. Since this is a minor version update, the risk of breaking changes is low, but testing is still recommended after merging.

I've summarized the release notes below for your convenience:

Given the nature of the change, there are no specific code style or efficiency suggestions within the diff hunks themselves. However, I recommend reviewing the updated library's documentation for any potential API changes or new features that could be leveraged in the project. Ensure your test suite has adequate coverage for the functionality that uses this library. I did not find a style guide provided, so I will default to PEP 8 for Python when making any style-related comments.

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Consider adding a comment explaining the reason for this version bump, referencing the bug fix included in 2.20.2. This will help with future maintainability and understanding the context of the change. For example, you could add a comment like # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575) above or below this line. Per PEP 8, comments are recommended to explain the purpose of specific dependency versions.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575)

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Similar to the previous suggestion, add a comment explaining the reason for updating to 2.20.2. Referencing the specific bug fix will make it easier to understand why this change was made in the future. For example, you could add a comment like # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575) above or below this line. Per PEP 8, comments are recommended to explain the purpose of specific dependency versions.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575)

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

It's a good idea to add a comment explaining the reason for this version change. Specifically mentioning the bug fix will provide valuable context for anyone reviewing this file later. For example, you could add a comment like # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575) above or below this line. Per PEP 8, comments are recommended to explain the purpose of specific dependency versions.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575)

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Consider adding a comment to explain why this dependency was updated to 2.20.2. Referencing the bug fix will help others understand the change and its importance. For example, you could add a comment like # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575) above or below this line. Per PEP 8, comments are recommended to explain the purpose of specific dependency versions.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575)

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Adding a comment explaining the reason for the version update is beneficial for maintainability. Mentioning the bug fix will provide context for future reviews. For example, you could add a comment like # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575) above or below this line. Per PEP 8, comments are recommended to explain the purpose of specific dependency versions.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575)

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

A comment explaining the reason for this version bump would be helpful. Specifically, referencing the bug fix will provide context for future maintainers. For example, you could add a comment like # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575) above or below this line. Per PEP 8, comments are recommended to explain the purpose of specific dependency versions.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Updated to 2.20.2 to fix list meaning preservation (see https://redirect.github.com/googleapis/python-datastore/issues/575)

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files in the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: The primary goal is to keep the project's dependencies up-to-date, leveraging the latest bug fixes and improvements included in version 2.20.2 of the google-cloud-datastore library.
  • Changes: The version number for google-cloud-datastore is updated in the following requirements.txt files:
    • appengine/flexible/datastore/requirements.txt
    • appengine/flexible_python37_and_earlier/datastore/requirements.txt
    • blog/introduction_to_data_models_in_cloud_datastore/requirements.txt
    • datastore/cloud-client/requirements.txt
    • dlp/snippets/requirements.txt
    • functions/v2/datastore/hello-datastore/requirements.txt

The release notes for google-cloud-datastore v2.20.2 mention a single bug fix related to preserving list meanings. This suggests a minor but potentially important update.

I'll provide a more detailed review shortly, but this should give everyone a head start.


A little poem for your coding pleasure:

The code compiles,
A bug is now vanquished,
Success, a sweet taste.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple services. The update includes a bug fix related to preserving list meanings. It's good practice to keep dependencies up-to-date, and the included changelog entry helps provide context for the change. I recommend testing thoroughly after merging to ensure the bug fix doesn't inadvertently affect any existing functionality. The detailed release notes and merge confidence badges suggest this is a low-risk change.

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating to 2.20.2 is a good move. To improve clarity and maintainability, consider adding an inline comment briefly explaining the reason for this specific version bump, referencing the bug fix. This helps provide context for future updates.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Bug fix: Preserve list meanings (#575)

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating to 2.20.2 addresses the list meaning preservation bug. A quick inline comment referencing the bug fix (#575) would be helpful for future reference.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Bug fix: Preserve list meanings (#575)

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Since this requirements.txt is for a blog post example, adding a comment explaining the reason for the update, and referencing the associated bug fix (#575), would be especially helpful for readers trying to understand the code's context.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Bug fix: Preserve list meanings (#575)

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

A short comment explaining the version update would improve maintainability and provide context for others working with this code. Referencing the bug fix (#575) would be beneficial.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Bug fix: Preserve list meanings (#575)

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

To enhance readability and maintainability, consider adding a comment explaining the reason for this version update. A reference to the bug fix (#575) would be valuable.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Bug fix: Preserve list meanings (#575)

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Adding an inline comment explaining the reason for this version bump (and referencing the bug fix #575) would be helpful for future maintainability and provide context for anyone working with this Cloud Function.

Suggested change
google-cloud-datastore==2.20.2
google-cloud-datastore==2.20.2 # Bug fix: Preserve list meanings (#575)

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files within the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: To keep dependencies up-to-date and benefit from bug fixes and potential improvements included in version 2.20.2 of the google-cloud-datastore library.
  • Changes: The version number of google-cloud-datastore is updated in the following files:
    • appengine/flexible/datastore/requirements.txt
    • appengine/flexible_python37_and_earlier/datastore/requirements.txt
    • blog/introduction_to_data_models_in_cloud_datastore/requirements.txt
    • datastore/cloud-client/requirements.txt
    • dlp/snippets/requirements.txt
    • functions/v2/datastore/hello-datastore/requirements.txt

The release notes for google-cloud-datastore v2.20.2 mention a single bug fix related to preserving list meanings. I'll verify this during my full review.


Here's a little poem to brighten your day:

A bot's gentle hand,
Updates code, a silent task,
Keeps the system grand.

Let me know if you have any questions. I'll post my full review shortly.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple samples. This is a good practice for ensuring bug fixes and potential performance improvements are integrated. The changelog mentions a bug fix related to preserving list meanings. While minor version updates generally don't introduce breaking changes, it's crucial to test thoroughly after merging.

I recommend reviewing the release notes for v2.20.2 and testing the affected samples to confirm the intended behavior. Also, ensure the relevant READMEs are updated to reflect the dependency change.

Here's a summary of the release notes:

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is a good practice. This version includes a bug fix for preserving list meanings. Ensure thorough testing of the application after merging this change.

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended. This version includes a bug fix for preserving list meanings. Test the application thoroughly after merging.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is a good practice. This version includes a bug fix for preserving list meanings. Test the sample application thoroughly after merging.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended. This version includes a bug fix for preserving list meanings. Test the sample application thoroughly after merging.

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is a good practice. This version includes a bug fix for preserving list meanings. Test the DLP snippets thoroughly after merging.

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updating google-cloud-datastore to 2.20.2 is recommended. This version includes a bug fix for preserving list meanings. Test the Cloud Function thoroughly after merging.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files in the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: To keep dependencies up-to-date and benefit from bug fixes and potential performance improvements included in version 2.20.2 of the google-cloud-datastore library.
  • Changes: The version number of google-cloud-datastore is updated in the following requirements.txt files:
    • appengine/flexible/datastore/requirements.txt (lines 2)
    • appengine/flexible_python37_and_earlier/datastore/requirements.txt (lines 3)
    • blog/introduction_to_data_models_in_cloud_datastore/requirements.txt (lines 1)
    • datastore/cloud-client/requirements.txt (lines 1)
    • dlp/snippets/requirements.txt (lines 4)
    • functions/v2/datastore/hello-datastore/requirements.txt (lines 3)

The release notes for google-cloud-datastore v2.20.2 mention a single bug fix related to preserving list meanings. This suggests a minor but potentially important update.

I'll provide a more detailed review shortly, but this should give you a good overview of the changes.


A little poem for your coding pleasure:

Code flows like a river,
Bugs hide beneath the surface,
Reviews bring the light.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple samples. Updating dependencies is crucial for incorporating bug fixes and potential performance improvements. The specific bug fix mentioned in the release notes, "Preserve list meanings (#575)", is important to understand in the context of your application. Ensure your code correctly handles list properties within Datastore.

While this is a minor version bump, it's good practice to test thoroughly after merging to catch any unexpected issues. Focus your testing on areas that interact with Datastore list properties to confirm the bug fix doesn't negatively impact existing functionality.

Recommendations before merging:

  • Review the full release notes: While the provided summary is helpful, it's always recommended to review the complete release notes for v2.20.2 of google-cloud-datastore. This will provide a comprehensive understanding of all changes, including other bug fixes, performance improvements, and any potentially breaking changes (though unlikely in a minor release). You can find the full release notes here: https://redirect.github.com/googleapis/python-datastore/blob/HEAD/CHANGELOG.md#2202-2024-12-12
  • Targeted testing: Prioritize testing scenarios that involve Datastore list properties to confirm the fix for issue Flaky transaction snippets #575 works as expected in your application.
  • Consider updating related documentation or comments: If the code changes impact any existing documentation or comments in your project, ensure they are updated to reflect the new dependency version and any relevant changes in functionality.

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated to google-cloud-datastore==2.20.2. Please refer to the release notes for this version to ensure no breaking changes affect this sample. Test thoroughly after merging, especially code that interacts with Datastore list properties.

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated to google-cloud-datastore==2.20.2. Please refer to the release notes for this version to ensure no breaking changes affect this sample. Test thoroughly after merging, especially code that interacts with Datastore list properties.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated to google-cloud-datastore==2.20.2. Please refer to the release notes for this version and test thoroughly after merging.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated to google-cloud-datastore==2.20.2. Please refer to the release notes for this version and test thoroughly after merging.

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated to google-cloud-datastore==2.20.2. While this is just a dependency update, it's a good idea to review the release notes for this version and test thoroughly after merging.

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated to google-cloud-datastore==2.20.2. Please refer to the release notes for this version and test thoroughly after merging.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my detailed feedback in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files in the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: The primary goal is to keep the project's dependencies up-to-date, leveraging the latest bug fixes and improvements included in google-cloud-datastore version 2.20.2. This is a routine maintenance task to ensure stability and access to the newest features.

  • Changes: The update affects the following files:

File Change
appengine/flexible/datastore/requirements.txt Updated google-cloud-datastore to 2.20.2
appengine/flexible_python37_and_earlier/datastore/requirements.txt Updated google-cloud-datastore to 2.20.2
blog/introduction_to_data_models_in_cloud_datastore/requirements.txt Updated google-cloud-datastore to 2.20.2
datastore/cloud-client/requirements.txt Updated google-cloud-datastore to 2.20.2
dlp/snippets/requirements.txt Updated google-cloud-datastore to 2.20.2
functions/v2/datastore/hello-datastore/requirements.txt Updated google-cloud-datastore to 2.20.2

The specific bug fix in google-cloud-datastore 2.20.2 (preserving list meanings) is detailed in the PR description. It's a relatively minor change, but important for data integrity.

I'll provide a more thorough review shortly.


And now, a little verse to lighten the mood:

Dependencies dance,
Versions rise, a graceful leap,
Code stays fresh and clean.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple services. The update includes a bug fix related to preserving list meanings (see https://redirect.github.com/googleapis/python-datastore/issues/575). It's good practice to keep dependencies up-to-date, so this change is recommended. Additionally, I've checked that the version bump is reflected correctly in each requirements.txt file and that the changes adhere to the guidance provided in AUTHORING_GUIDE.md regarding dependency management.

Referenced Style Guide Elements:

  • Dependencies: The requirements.txt files are updated correctly, pinning the dependency to the new version. This adheres to the recommendation to pin dependencies to specific versions (AUTHORING_GUIDE.md).
  • Testing: It is good practice to run tests after any dependency updates to ensure that the update does not introduce any regressions. Please ensure that all relevant tests pass before merging this PR (AUTHORING_GUIDE.md).

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Bumping the version of the google-cloud-datastore package to 2.20.2 is a good practice to pick up the latest bug fixes and security updates, per the guidance in AUTHORING_GUIDE.md.

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Bumping the version of the google-cloud-datastore package to 2.20.2 is a good practice to pick up the latest bug fixes and security updates, per the guidance in AUTHORING_GUIDE.md.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Bumping the version of the google-cloud-datastore package to 2.20.2 is a good practice to pick up the latest bug fixes and security updates, per the guidance in AUTHORING_GUIDE.md.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Bumping the version of the google-cloud-datastore package to 2.20.2 is a good practice to pick up the latest bug fixes and security updates, per the guidance in AUTHORING_GUIDE.md.

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Bumping the version of the google-cloud-datastore package to 2.20.2 is a good practice to pick up the latest bug fixes and security updates, per the guidance in AUTHORING_GUIDE.md.

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Bumping the version of the google-cloud-datastore package to 2.20.2 is a good practice to pick up the latest bug fixes and security updates, per the guidance in AUTHORING_GUIDE.md.

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several files in the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: The primary goal is to keep dependencies up-to-date, improving security and leveraging potential bug fixes and performance enhancements included in the newer version.
  • Changes: The google-cloud-datastore version has been updated in the following files:
    • appengine/flexible/datastore/requirements.txt
    • appengine/flexible_python37_and_earlier/datastore/requirements.txt
    • blog/introduction_to_data_models_in_cloud_datastore/requirements.txt
    • datastore/cloud-client/requirements.txt
    • dlp/snippets/requirements.txt
    • functions/v2/datastore/hello-datastore/requirements.txt

The release notes for google-cloud-datastore v2.20.2 mention a single bug fix related to preserving list meanings (googleapis/python-datastore#575). This suggests a minor but potentially important update.

I'll provide a more detailed review shortly, but this should give you a good overview of the changes.


A little poem for your coding pleasure:

Small change, big impact,
Dependency's gentle nudge,
Code runs smoother now.

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple services. This is a good practice to keep dependencies up-to-date. The provided release notes and merge confidence badges from Renovate are helpful. I've linked the bug fix (#575) in the review comments for more context. Since this is a minor version update, the risk of breaking changes is low. However, please test thoroughly after merging.

I recommend updating any relevant READMEs or documentation to reflect this dependency update. For example, if you have a section listing dependencies or a setup guide, make sure it mentions google-cloud-datastore==2.20.2. This will help ensure that your documentation stays consistent with the code.

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated google-cloud-datastore to 2.20.2. This addresses a bug related to preserving list meanings (see issue #575).

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated google-cloud-datastore to 2.20.2. This addresses a bug related to preserving list meanings (see issue #575).

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated google-cloud-datastore to 2.20.2. This addresses a bug related to preserving list meanings (see issue #575).

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated google-cloud-datastore to 2.20.2. This addresses a bug related to preserving list meanings (see issue #575).

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated google-cloud-datastore to 2.20.2. This addresses a bug related to preserving list meanings (see issue #575).

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Updated google-cloud-datastore to 2.20.2. This addresses a bug related to preserving list meanings (see issue #575).

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will have a full review ready in a few minutes. In the meantime, here's a quick summary for you and other reviewers to get up to speed:

This pull request, submitted by Renovate Bot, updates the google-cloud-datastore dependency across several example applications within the python-docs-samples repository. The update bumps the version from 2.20.1 to 2.20.2.

Here's a breakdown of the changes:

  • Intent: Maintain up-to-date dependencies to benefit from bug fixes and potential performance improvements in the latest google-cloud-datastore release.
  • Changes: The version of google-cloud-datastore is updated in the requirements.txt files of the following directories:
    • appengine/flexible/datastore
    • appengine/flexible_python37_and_earlier/datastore
    • blog/introduction_to_data_models_in_cloud_datastore
    • datastore/cloud-client
    • dlp/snippets
    • functions/v2/datastore/hello-datastore

The specific bug fix included in google-cloud-datastore 2.20.2 is detailed in the PR description and addresses the preservation of list meanings (Issue #575 in the googleapis/python-datastore repository).

All changes are limited to updating the version number in the respective requirements.txt files. No other code modifications were made.

Here's a little something to brighten your day:

Small change, it seems,
But keeps our code fresh and clean,
A better world gleams.

Looking forward to your feedback!

Best,
Gemini

Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the google-cloud-datastore dependency to version 2.20.2 across multiple services. Updating dependencies is crucial for leveraging bug fixes and performance improvements. The changelog provided in the PR description indicates a bug fix related to preserving list meanings, which is a good reason for this update.

While the change itself is simple, it's important to ensure consistency across all requirements.txt files and consider the implications for different Python versions. I've added a few suggestions below to address these points. I recommend thorough testing after merging to ensure the update doesn't introduce any regressions.

@@ -1,3 +1,3 @@
Flask==3.0.3
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The dependency has been updated correctly to 2.20.2. Per PEP 8, using == to pin the dependency to a specific version is generally recommended for better control and reproducibility. This helps avoid unexpected issues if future minor versions introduce breaking changes. However, if the project intends to use the latest minor version within the 2.20.x series, using ~=2.20.0 would be appropriate.

@@ -1,5 +1,5 @@
Flask==3.0.3; python_version > '3.6'
Flask==2.3.3; python_version < '3.7'
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The dependency update is correct. Consider pinning to the exact version (==) for consistency with other environments and to prevent potential issues from automatic minor version updates. Alternatively, if the goal is to allow updates within the 2.20.x series, use ~=2.20.0. It's important to document the project's dependency management strategy to clarify the intended behavior.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The update to 2.20.2 is correct. For better control over dependency versions, consider pinning to the exact version using ==. Alternatively, if you intend to use the latest 2.20.x release, use ~=2.20.0. This will prevent unexpected issues if a future 2.20.x release introduces breaking changes. It's also good practice to document your dependency management strategy in the project's documentation or README.

@@ -1 +1 @@
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Correct update to 2.20.2. Consider explicitly pinning the version with == for reproducibility. If the intention is to automatically update to newer minor versions within the 2.20 series, use ~=2.20.0. This makes the dependency management strategy clear and helps avoid unexpected issues from breaking changes in minor releases.

@@ -1,5 +1,5 @@
google-cloud-dlp==3.25.1
google-cloud-storage==2.9.0
google-cloud-pubsub==2.21.5
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The google-cloud-datastore dependency is correctly updated. Consider using == to pin the version for better control and reproducibility. Alternatively, if the project intends to use the latest minor version within the 2.20.x series, using ~=2.20.0 would be more appropriate. This helps avoid unexpected issues if a new minor version introduces breaking changes.

@@ -1,6 +1,6 @@
functions-framework==3.5.0
google-events==0.11.0
google-cloud-datastore==2.20.1
google-cloud-datastore==2.20.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

The dependency is correctly updated to 2.20.2. It's generally a good practice to pin the dependency to a specific version using == for reproducibility. If the project's policy is to use the latest minor version within the 2.20.x series, then using ~=2.20.0 would be appropriate. This helps avoid unexpected issues if a future minor version introduces breaking changes.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2025
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 21, 2025
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 21, 2025
@glasnt
Copy link
Contributor

glasnt commented Jan 21, 2025

These tests are succeeding on periodic but not on this PR. Trying to replicate the issue locally I got a number of errors:

 400 The query requires an ASC or DESC index for kind employees and property salary. Please use the gcloud CLI to remove the single-property index exemption for this property.

On a project with a native Datastore

google.api_core.exceptions.FailedPrecondition: 400 One possible index to serve the query is:
- kind: Task
  properties:
  - name: days
  - name: priority
The query contains range and inequality filters on multiple fields, please refer to the documentation for index selection best practices: https://cloud.google.com/datastore/docs/multiple-range-fields. 

On a new project with just Datastore (in Datastore mode) enabled.

This message went away when I ran gcloud datastore indexes create index.yaml within the directory and waited for the indexes to be ready.

These instructions don't appear to be on the sample or reference docs; also the python version test projects don't have all these indexes, but the proper project does (unsure which project these tests run)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: appengine Issues related to the App Engine Admin API API. api: cloudfunctions Issues related to the Cloud Run functions API. api: datastore Issues related to the Datastore API. api: dlp Issues related to the Sensitive Data Protection API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants