Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Melpa package of magithub broken #11

Open
michael-heerdegen opened this issue Aug 17, 2013 · 11 comments
Open

Melpa package of magithub broken #11

michael-heerdegen opened this issue Aug 17, 2013 · 11 comments

Comments

@michael-heerdegen
Copy link

Hello,

I have magit and magithub installed with M-x package-list-packages. When I try to load magit (yes, magit, not magithub), I get this error:

(void-variable magit-log-edit-confirm-cancellation)

This is what's happening:

  • loading magit triggers loading magithub because of

;;;###autoload
(eval-after-load 'magit
'(unless (featurep 'magithub)
(require 'magithub)))

  • in magithub, there is this form:

(defcustom magithub-message-confirm-cancellation magit-log-edit-confirm-cancellation
"If non-nil, confirm when cancelling the editing of a `magithub-message-mode' buffer."
:group 'magithub
:type 'boolean)

  • evaluating it raises the error because magit-log-edit-confirm-cancellation is not defined.

Maybe the variable has been removed? Dunno.

Michael.
@pashinin
Copy link

Confirm

@pokehanai
Copy link

+1

expez added a commit to expez/magithub that referenced this issue Aug 19, 2013
@expez
Remove dependence on void magit variable
5c74fa2 
The variable magit-log-edit-confirm-cancellation appears to be removed from magit, causing magithub to crash the initialization of magit.

Fixes nex3#11
@expez expez mentioned this issue Aug 19, 2013
Closed
@aspiers
Copy link

aspiers commented Aug 20, 2013

+1

@praet praet mentioned this issue Aug 21, 2013
Closed
@jasonm23
Copy link

jasonm23 commented Sep 3, 2013

Question, why is this closed when the MELPA install is still broken?

@flexibeast
Copy link

@jasonm23:

As far as I can tell, looking at the issue status indicator at the top of this page, this issue isn't closed. If I'm understanding things correctly, the 'Closed' indicator earlier in this thread is a reference to the issue being closed on the /magit/ repo, as the issue is not with magit itself, but with /magithub/, a distinct project.

@jasonm23
Copy link

jasonm23 commented Sep 3, 2013

@flexibeast thanks for clearing that up. It seems that the melpa package is still a release from July. (?)

@flexibeast
Copy link

@jasonm23:

Yes, that's the latest release I'm seeing also .... Basically I've uninstalled magithub until this issue is fixed, so that I can at least continue using magit.

@Blaisorblade
Copy link

I had the same problem.
It seems that saving magithub-message-confirm-cancellation from M-x customize-group RET magithub RET also works the problem around (I guess because once the variable is set, reading the default isn't needed any more).

@dcunited001
Copy link

+1

@alexvorobiev
Copy link

Adding (defvar magit-log-edit-confirm-cancellation nil) prior to loading magit is another workaround.

@npostavs npostavs mentioned this issue Oct 19, 2013
Closed
@tarsius tarsius mentioned this issue Oct 23, 2013
Closed
@Blaisorblade
Copy link

Apparently magithub is unsupported and does not work anyway, see melpa/melpa#1126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependence on void magit variable expez/magithub
9 participants
@jasonm23 @aspiers @flexibeast @Blaisorblade @alexvorobiev @dcunited001 @pokehanai @pashinin @michael-heerdegen