-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pendingToken from public API. #2676
Conversation
…istake. Developers are not supposed to use it, and they currently have no way to use it.
Hey Morgan --- We accidentally added a private field to public API. Do you know what's the process to remove it? Unlike last time (Microsoft/Yahoo provider ID), this time developer won't use this field at all. Even they grabbed this token, they can do nothing about it. It's a field of no use case at all. I was wondering in this case can we just remove this from the public header? |
It may be ok to do this API change without a deprecation along with the major release update, but it should be cleared with @ryanwilson. |
Hi @ryanwilson we accidentally left a private property in public header. Developer won't use it as there's absolutely no use case at all. I would consider this a bug. Is it ok to remove it in the next release? |
I think I'm okay with this but I'm not thrilled about it - can we have a discussion at some point soon about how this was released, and what steps are being taken in the future to avoid something like this happening? Having the very large PR (#2405) hurt the review-ability and introduced more than one issue with the public interface. |
I sent you an email discussing the issue. Let's continue the discussion internally. |
…istake. (#2676) Developers are not supposed to use it, and they currently have no way to use it.
It's added to public header by mistake.
Developers are not supposed to use it, and they currently have no way to use it.