Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove InstanceID from Github repo #7970

Merged
merged 12 commits into from
Apr 27, 2021
Merged

Remove InstanceID from Github repo #7970

merged 12 commits into from
Apr 27, 2021

Conversation

charlotteliang
Copy link
Contributor

Sunsetting Firebase InstanceID and please use Firebase Installations to manage app identifier and use Firebase Messaging to manage FCM registration token.
See migration guide: https://firebase.google.com/docs/projects/manage-installations#fid-iid

@google-cla google-cla bot added the cla: yes label Apr 26, 2021
maksymmalyhin
maksymmalyhin approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

−13,361 line of code 🎉

LGTM on CI green

@paulb777
Copy link
Member

See the results of git grep -i instanceid.

Some other removals are needed across scripts, ReleaseTooling, Dangerfile, .github/workflows/instanceid.yml, .travis.yml, FirebaseAuth/Tests/Sample/Podfile

@google-oss-bot
Copy link

google-oss-bot commented Apr 26, 2021 •
edited
Loading

Coverage Report

Affected SDKs

No changes between base commit (46e3293) and head commit (686820c).

Test Logs

@paulb777
Copy link
Member

Needs a rebase or a merge to run CI

@charlotteliang charlotteliang requested a review from karenyz April 27, 2021 18:40
@charlotteliang charlotteliang merged commit 429bac4 into master Apr 27, 2021
@charlotteliang charlotteliang deleted the chen-remove-instanceid branch April 27, 2021 18:54
@paulb777 paulb777 mentioned this pull request Apr 28, 2021
Closed
@rsattar
Copy link
Contributor

rsattar commented May 8, 2021

Woo hoo! 🎉
LGTM! 😄 ❤️

@kdhrubo kdhrubo mentioned this pull request May 19, 2021
Closed
@firebase firebase locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@maksymmalyhin maksymmalyhin maksymmalyhin approved these changes

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

@ashwinraghav ashwinraghav Awaiting requested review from ashwinraghav

@karenyz karenyz Awaiting requested review from karenyz

Assignees
No one assigned
Labels
api: auth api: core api: functions api: installations api: messaging api: remoteconfig cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@charlotteliang @paulb777 @google-oss-bot @rsattar @maksymmalyhin @morganchen12 @sluckbla197