Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging - no typedefs in public APIs #6278

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Messaging - no typedefs in public APIs #6278

merged 2 commits into from
Aug 17, 2020

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Aug 14, 2020

From

Screen Shot 2020-08-14 at 3 07 22 PM

to

Screen Shot 2020-08-14 at 3 30 59 PM

Copy link
Contributor

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably update my new API review to follow this format.

@@ -396,7 +396,8 @@ NS_SWIFT_NAME(Messaging)
* @param completion The completion handler to handle the token request.
*/
- (void)retrieveFCMTokenForSenderID:(NSString *)senderID
completion:(FIRMessagingFCMTokenFetchCompletion)completion
completion:(void (^_Nonnull)(NSString *_Nullable FCMToken,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is nonnull by default?

@paulb777 paulb777 merged commit b84e42d into master Aug 17, 2020
@paulb777 paulb777 deleted the pb-msg-typedef branch August 17, 2020 17:05
@firebase firebase locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants