Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better warning for misspelled files #11317

Merged
merged 4 commits into from
May 23, 2023
Merged

Add better warning for misspelled files #11317

merged 4 commits into from
May 23, 2023

Conversation

morganchen12
Copy link
Contributor

No description provided.

@morganchen12 morganchen12 requested a review from andrewheard May 22, 2023 22:34
andrewheard
andrewheard approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks!

FirebaseCore/Sources/FIRApp.m Outdated Show resolved Hide resolved
@paulb777
Copy link
Member

Please fix ci

@morganchen12
Copy link
Contributor Author

Tested locally and it works as expected.

2023-05-23 13:43:13.340213-0700 AuthenticationExample[49110:6833337] *** Terminating app due to uncaught exception 'com.firebase.core', reason: '`FirebaseApp.configure()` could not find the default configuration plist in your project, but did find one at /Users/morganchen/Library/Developer/CoreSimulator/Devices/21552B4A-FC19-456F-AB44-D7A588594994/data/Containers/Bundle/Application/CD377DAB-0E09-4D4B-98F4-1C79EBA6245E/AuthenticationExample.app/GoogleService-Info .plist. Please rename this file to GoogleService-Info.plist to use it as the default configuration.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007ff800427378 __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007ff80004dbaf objc_exception_throw + 48
	2   CoreFoundation                      0x00007ff800427256 -[NSException initWithCoder:] + 0
	3   FirebaseCore                        0x0000000108cdda6d +[FIRApp configure] + 813
	4   AuthenticationExample               0x000000010870d6d9 -[AppDelegate application:didFinishLaunchingWithOptions:] + 89
	5   UIKitCore                           0x000000010edeb193 -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] + 271
	6   UIKitCore                           0x000000010edecf34 -[UIApplication _callInitializationDelegatesWithActions:forCanvas:payload:fromOriginatingProcess:] + 4257
	7   UIKitCore                           0x000000010edf2bf5 -[UIApplication _runWithMainScene:transitionContext:completion:] + 1236
	8   UIKitCore                           0x000000010e22f19c -[_UISceneLifecycleMultiplexer completeApplicationLaunchWithFBSScene:transitionContext:] + 122
	9   UIKitCore                           0x000000010e89e9f5 _UIScenePerformActionsWithLifecycleActionMask + 88
	10  UIKitCore                           0x000000010e22fc96 __101-[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:]_block_invoke + 198
	11  UIKitCore                           0x000000010e22f6d3 -[_UISceneLifecycleMultiplexer _performBlock:withApplicationOfDeactivationReasons:fromReasons:] + 252
	12  UIKitCore                           0x000000010e22facc -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] + 831
	13  UIKitCore                           0x000000010e22f379 -[_UISceneLifecycleMultiplexer uiScene:transitionedFromState:withTransitionContext:] + 354
	14  UIKitCore                           0x000000010e23e1a0 __186-[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:]_block_invoke + 178
	15  UIKitCore                           0x000000010e76fe53 +[BSAnimationSettings(UIKit) tryAnimatingWithSettings:fromCurrentState:actions:completion:] + 833
	16  UIKitCore                           0x000000010e8bca90 _UISceneSettingsDiffActionPerformChangesWithTransitionContextAndCompletion + 257
	17  UIKitCore                           0x000000010e23de20 -[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:] + 348
	18  UIKitCore                           0x000000010e022523 __64-[UIScene scene:didUpdateWithDiff:transitionContext:completion:]_block_invoke.595 + 815
	19  UIKitCore                           0x000000010e020f39 -[UIScene _emitSceneSettingsUpdateResponseForCompletion:afterSceneUpdateWork:] + 245
	20  UIKitCore                           0x000000010e0220d0 -[UIScene scene:didUpdateWithDiff:transitionContext:completion:] + 255
	21  UIKitCore                           0x000000010edf143b -[UIApplication workspace:didCreateScene:withTransitionContext:completion:] + 733
	22  UIKitCore                           0x000000010e7a27e0 -[UIApplicationSceneClientAgent scene:didInitializeWithEvent:completion:] + 350
	23  FrontBoardServices                  0x00007ff805445c8a -[FBSScene _callOutQueue_agent_didCreateWithTransitionContext:completion:] + 415
	24  FrontBoardServices                  0x00007ff805473deb __92-[FBSWorkspaceScenesClient createSceneWithIdentity:parameters:transitionContext:completion:]_block_invoke.187 + 102
	25  FrontBoardServices                  0x00007ff805453cda -[FBSWorkspace _calloutQueue_executeCalloutFromSource:withBlock:] + 209
	26  FrontBoardServices                  0x00007ff8054739e0 __92-[FBSWorkspaceScenesClient createSceneWithIdentity:parameters:transitionContext:completion:]_block_invoke + 344
	27  libdispatch.dylib                   0x00000001096bef5b _dispatch_client_callout + 8
	28  libdispatch.dylib                   0x00000001096c28d2 _dispatch_block_invoke_direct + 496
	29  FrontBoardServices                  0x00007ff80549a6c0 __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ + 30
	30  FrontBoardServices                  0x00007ff80549a5b6 -[FBSSerialQueue _targetQueue_performNextIfPossible] + 174
	31  FrontBoardServices                  0x00007ff80549a6e8 -[FBSSerialQueue _performNextFromRunLoopSource] + 19
	32  CoreFoundation                      0x00007ff800386ebd __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
	33  CoreFoundation                      0x00007ff800386dfc __CFRunLoopDoSource0 + 157
	34  CoreFoundation                      0x00007ff8003865f9 __CFRunLoopDoSources0 + 212
	35  CoreFoundation                      0x00007ff800380db3 __CFRunLoopRun + 927
	36  CoreFoundation                      0x00007ff800380637 CFRunLoopRunSpecific + 560
	37  GraphicsServices                    0x00007ff809c0f28a GSEventRunModal + 139
	38  UIKitCore                           0x000000010edef425 -[UIApplication _run] + 994
	39  UIKitCore                           0x000000010edf4301 UIApplicationMain + 123
	40  AuthenticationExample               0x000000010870de28 main + 104
	41  dyld                                0x0000000108a0d2bf start_sim + 10
	42  ???                                 0x000000010dec541f 0x0 + 4528559135
)
libc++abi: terminating with uncaught exception of type NSException
*** Terminating app due to uncaught exception 'com.firebase.core', reason: '`FirebaseApp.configure()` could not find the default configuration plist in your project, but did find one at /Users/morganchen/Library/Developer/CoreSimulator/Devices/21552B4A-FC19-456F-AB44-D7A588594994/data/Containers/Bundle/Application/CD377DAB-0E09-4D4B-98F4-1C79EBA6245E/AuthenticationExample.app/GoogleService-Info .plist. Please rename this file to GoogleService-Info.plist to use it as the default configuration.'
terminating with uncaught exception of type NSException
CoreSimulator 857.7 - Device: iPhone 14 Pro (21552B4A-FC19-456F-AB44-D7A588594994) - Runtime: iOS 16.0 (20A360) - DeviceType: iPhone 14 Pro

@morganchen12 morganchen12 added this to the 10.11.0 - M133 milestone May 23, 2023
paulb777
paulb777 approved these changes May 23, 2023
View reviewed changes
FirebaseCore/Sources/FIRApp.m Outdated Show resolved Hide resolved
@morganchen12 morganchen12 merged commit 3805752 into master May 23, 2023
@morganchen12 morganchen12 deleted the mc/better-crash branch May 23, 2023 21:15
@firebase firebase locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewheard andrewheard andrewheard approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: core
Projects
None yet
Milestone
10.11.0 - M133
Development

Successfully merging this pull request may close these issues.
4 participants
@morganchen12 @paulb777 @andrewheard @google-oss-bot