Expand on Response annotation warning message. #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example of how it would look in a Symfony project:
|
|
I like the idea, however it might be good to handle all sorts of contexts - similar to https://github.com/zircote/swagger-php/blob/master/src/Processors/OperationId.php#L54-L72 In fact, there enums are missing too! I suppose the |
|
I went over the code and noticed that I updated my PR to reflect the change. Attaching an example message: I don't have time to go over all the warning/error messages, I'll update them one by one if/when I encounter them. |
kevinkopf
force-pushed
the
response-error-hint
branch
from
ffecb61 to
1475d41
Compare
|
Oops |
DerManoMann
approved these changes
Jan 6, 2025
|
Thanks @kevinkopf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
descriptionorrefis missing inResponseannotation, this improves the warning message, telling where exactly the missing attribute for the annotation is, saving up one's debugging time.