[WIP] Move to trait based version Expect
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiburt
changed the title
Expect
|
Thanks for the heads up @zhiburt and good luck with the trait refactor. It was actually quite urgent for me so I forked and made the changes I needed. Great work with this library! |
|
Seems like I am done; You can check it out @tmpfs; And one more Take care |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I very much think it's getting nicer than it was internally.
Just wanted to let you @tmpfs know what I meant when I said it will be pretty hard to switch to trait based version.
It's almost finished
syncversion. But yet there a small ride to do.And yes if you still interested you can send a PR with a logger improvement.