SC2016: Expressions don't expand in single quotes, use double quotes for that.

shellcheck is too clever for itself. I kinda hate that tool. I am using single quotes here to -not- expand the expression passed to git foreach. a lot of what shellcheck does it is style and opinion based. In this particular case it is flat out wrong.

I guess I can write a test to verify that new files are put in place as expected, also when switching environments.

@tox2ik - Just so you are aware, this PR wasn't being ignored because of the shellcheck failure. I've merely have very little time to devote to yadm over the past few months. I think more time should be freeing up soon....

Looking at your test configuration now. I'm sure you have reasons, by my-my does it feel over-engineered. It's ok that you may want to run the tests in a container (controlled environment), but forcing everyone to run them in a container is overkill. When the tools advance, and dependencies progress, your testbed (yadm/testbed:2020-01-20) will become obsolete. And in effect, the test will only verify some "ancient" environment that no one cares about (imagine you cannot maintain project for 3+ years)

Not sure I have a point other than I'd like to run the tests natively, or at least understand the python setup. Given a "bash perspective", the current setup (Makefile; test) does everythig to prevent that.

Also, testing bash with python feels contrived. I'll do my best to comply and understand what's going on, but you are forsing me to - instead of writing a bash script to verify funtionality, I now need to learn a whole new setup that I have never heard of before.

The whole docker-compose aspect of image: yadm/testbed:2020-01-20, seems to be completely outside of the project. Where tf are the instructions to build that image? Further, make testenv seems somewhat relevant, but I still dont understand how to run the tests form that. Either I am
a complete moron, or you need to explain wtf is going on. At least hint at some tutorial that uses this test-environment setup in the readme.

I appreciate your time and this project.

docker-compose is no longer used to run the tests (on the develop branch). They are instead run using just docker. The Dockerfile used to create the test image is in the test directory. You can build the image yourself with make image.

To run all tests just do make test. To run a single test you can do e.g. make test testargs=test/test_init.py.

As for shellcheck you can ignore specific lines if you want.