Plugin error messages (#798)

wulkano · Feb 16, 2020 · e094413 · e094413
1 parent 3b29d58
commit e094413
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 5 deletions.
diff --git a/main/export-list.js b/main/export-list.js
@@ -102,8 +102,15 @@ class ExportList {
         this.currentExport.updateExport({
           status: 'failed',
           text: 'Export failed',
-          error: error.stack
+          error: {stack: error.stack, message: error.message}
         });
+
+        const notification = new Notification({
+          title: this.currentExport.pluginName,
+          body: error.message
+        });
+        notification.show();
+
         delete this.currentExport;
         this._startNext();
       }

diff --git a/renderer/components/exports/export.js b/renderer/components/exports/export.js
@@ -53,7 +53,8 @@ export default class Export extends React.Component {
       text,
       percentage,
       image,
-      cancel
+      cancel,
+      error
     } = this.props;
     const {menu} = this.state;
 
@@ -96,7 +97,7 @@ export default class Export extends React.Component {
           <div className={fileNameClassName}>
             {defaultFileName}
           </div>
-          <div className="subtitle">{text}</div>
+          <div className="subtitle" title={error && error.message}>{text}{error && ` - ${error.message}`}</div>
         </div>
         <style jsx>{`
           .export-container {
@@ -139,6 +140,7 @@ export default class Export extends React.Component {
 
           .details {
             flex: 1;
+            width: 234px;
           }
 
           .title {
@@ -158,6 +160,10 @@ export default class Export extends React.Component {
             font-size: 12px;
             color: var(--subtitle-color);
             user-select: none;
+            width: 100%;
+            white-space: nowrap;
+            overflow: hidden;
+            text-overflow: ellipsis;
           }
 
           .export-container:hover {
@@ -187,5 +193,8 @@ Export.propTypes = {
   cancel: PropTypes.elementType,
   openInEditor: PropTypes.elementType,
   filePath: PropTypes.string,
-  createdAt: PropTypes.string
+  createdAt: PropTypes.string,
+  error: PropTypes.objectOf({
+    message: PropTypes.string
+  })
 };
diff --git a/renderer/containers/exports.js b/renderer/containers/exports.js
@@ -27,7 +27,7 @@ export default class ExportsContainer extends Container {
       exports.unshift(updates);
     } else {
       if (!exports[index].error && updates.error) {
-        console.error(updates.error);
+        console.error(updates.error.stack);
       }
 
       exports[index] = updates;