✨feat(renderer): support rate cell render #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maple13
force-pushed
the
maple13/render-rate
branch
2 times, most recently
from
20a3d62
to
fed44bb
Compare
cmm-va
reviewed
Sep 27, 2024
huanhuanwa
reviewed
Sep 27, 2024
| @@ -10,5 +10,6 @@ export const Colors = { | |||
| transparent: 'transparent', | |||
| gray80: '#fafafa', | |||
| headSelectedBgColor: '#EAEFFA', | |||
| itemActiveBgColor: '#6698ff1a' | |||
| itemActiveBgColor: '#6698ff1a', | |||
There was a problem hiding this comment.
headSelectedBgColor、itemActiveBgColor 的命名和其他的保持规则一致吧
There was a problem hiding this comment.
这两个没有相应的组件库参照，所以按照用途来了
packages/grid/src/renderer/components/placeholder-cells.component.ts
Outdated
Show resolved
Hide resolved
Maple13
force-pushed
the
maple13/render-rate
branch
from
fed44bb
to
a9c0675
Compare
packages/grid/src/components/cell-editors/rating/rating-editor.component.ts
Outdated
Show resolved
Hide resolved
pubuzhixing8
approved these changes
Sep 29, 2024
Maple13
force-pushed
the
maple13/render-rate
branch
from
a9c0675
to
7c18436
Compare
pubuzhixing8
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.