NODE-5888 use user token with group name #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexorekhov
reviewed
Dec 3, 2024
test/e2e/run-chart-test.sh
Outdated
| @@ -16,6 +16,9 @@ | |||
|
|
|||
| KIND_LOG_LEVEL="1" | |||
|
|
|||
| # generate unique group name | |||
| export NODE_GROUP_NAME="github-sidecar-$(tr -dc A-Za-z0-9 </dev/urandom | head -c 12; echo)" | |||
There was a problem hiding this comment.
Are you sure there should be sidecar?
alexorekhov
reviewed
Dec 3, 2024
test/e2e/run-e2e-suite.sh
Outdated
| @@ -28,6 +28,9 @@ set -o errexit | |||
| set -o nounset | |||
| set -o pipefail | |||
|
|
|||
| # generate unique group name | |||
| export NODE_GROUP_NAME="github-sidecar-$(tr -dc A-Za-z0-9 </dev/urandom | head -c 12; echo)" | |||
alexorekhov
reviewed
Dec 3, 2024
test/e2e/run-kind-e2e.sh
Outdated
| @@ -60,6 +60,9 @@ SKIP_INGRESS_IMAGE_CREATION="${SKIP_INGRESS_IMAGE_CREATION:-false}" | |||
| SKIP_E2E_IMAGE_CREATION="${SKIP_E2E_IMAGE_CREATION:=false}" | |||
| SKIP_CLUSTER_CREATION="${SKIP_CLUSTER_CREATION:-false}" | |||
|
|
|||
| # generate unique group name | |||
| export NODE_GROUP_NAME="github-sidecar-$(tr -dc A-Za-z0-9 </dev/urandom | head -c 12; echo)" | |||
alexorekhov
reviewed
Dec 3, 2024
test/smoke/run.sh
Outdated
| source "${PWD}/test/smoke/functions.sh" | ||
|
|
||
| # generate unique group name | ||
| export NODE_GROUP_NAME="github-sidecar-$(tr -dc A-Za-z0-9 </dev/urandom | head -c 12; echo)" |
dmironov-wallarm
force-pushed
the
feature/NODE-5888_use_node_groups
branch
from
c3044f4 to
e527899
Compare
alexorekhov
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use user token + group_name instead of node token