Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow relative path for VUE_CLI_CONTEXT #3548

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Allow relative path for VUE_CLI_CONTEXT #3548

wants to merge 1 commit into from

Conversation

DoHe
Copy link

@DoHe DoHe commented Feb 28, 2019

As stated in the title this allows to pass a relative path as a value for VUE_CLI_CONTEXT. It is assumed to be relative to the current working directory.
This addresses (part of) #3152

pksunkara
pksunkara suggested changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please make a generic function in util and use it in both places here.

@weixiao-huang
Copy link

is there any update of this PR?

@Dante-dan
Copy link

how about with this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pksunkara pksunkara pksunkara requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR: New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DoHe @weixiao-huang @Dante-dan @pksunkara @haoqunjiang