Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hillaI18n Feature flags for experimental features is ignored in production mode #2750

Closed
jcgueriaud1 opened this issue Sep 20, 2024 · 5 comments
Closed

hillaI18n Feature flags for experimental features is ignored in production mode #2750

jcgueriaud1 opened this issue Sep 20, 2024 · 5 comments
Assignees
@cromoteca
Labels
BFP Bugfix priority, also known as Warranty bug Something isn't working hilla Issues related to Hilla Impact: High Severity: Blocker

Comments

@jcgueriaud1
Copy link

Describe the bug

This issue is still happening in Vaadin 24.4.12 and Vaadin 24.5.0.beta1.

#2637

I have a file vaadin-featureflags.properties which contains com.vaadin.experimental.hillaI18n=true. In my local environment, the i18n-instance can be used without problems. However, in my production build, the frontend crashes with the error The Hilla I18n API is currently considered experimental and may change in the future. To use it you need to explicitly enable it in Copilot or by adding com.vaadin.experimental.hillaI18n=true to vaadin-featureflags.properties.

Expected-behavior

No response

Reproduction

https://github.com/jcgueriaud1/spring-petclinic-vaadin-flow/tree/hilla

Build and run the application in production mode

System Info

Vaadin 24.4.12 and Vaadin 24.5.0.beta1
@jcgueriaud1 jcgueriaud1 added bug Something isn't working hilla Issues related to Hilla labels Sep 20, 2024
@platosha
Copy link
Contributor

Last time this was caused by using a wrong class loader when generating feature flags TypeScript values in production build.

@cromoteca cromoteca self-assigned this Sep 25, 2024
@cromoteca cromoteca mentioned this issue Oct 8, 2024
Merged
@cromoteca cromoteca added the BFP Bugfix priority, also known as Warranty label Oct 21, 2024
@cromoteca
Copy link
Contributor

Fixed in 24.6 by vaadin/platform#6897, cherry-picked to 24.5 and 24.4. It will be included in the next patch releases.

@jcgueriaud1
Copy link
Author

Fixed in 24.5.1

@sveinnetnordic
Copy link

Works for me :-)

@cromoteca
Copy link
Contributor

Released in 24.5.1 and 24.4.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cromoteca cromoteca

Labels
BFP Bugfix priority, also known as Warranty bug Something isn't working hilla Issues related to Hilla Impact: High Severity: Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@platosha @cromoteca @jcgueriaud1 @sveinnetnordic