Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stl_file to threemf_file for from_3mf #100

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Update stl_file to threemf_file for from_3mf #100

merged 3 commits into from
Oct 3, 2024

Conversation

kiuber
Copy link
Contributor

@kiuber kiuber commented Sep 25, 2024

No description provided.

@gyscos
Copy link
Contributor

gyscos commented Sep 25, 2024 •
edited
Loading

Might be worth renaming it also in Mesh::load just above.

Might be easier to just call it input_file everywhere.

@kiuber
Copy link
Contributor Author

kiuber commented Sep 26, 2024

How about call it model_file? Please help review. thanks.

gyscos
gyscos approved these changes Sep 26, 2024
View reviewed changes
src/mesh.rs Outdated Show resolved Hide resolved
@kiuber kiuber requested a review from unlimitedbacon October 2, 2024 01:40
@unlimitedbacon unlimitedbacon merged commit 6bc9057 into unlimitedbacon:master Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyscos gyscos gyscos approved these changes

@unlimitedbacon unlimitedbacon Awaiting requested review from unlimitedbacon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiuber @gyscos @unlimitedbacon