Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure support for various versions of Faraday #583

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ensure support for various versions of Faraday #583

wants to merge 4 commits into from

Conversation

philsturgeon
Copy link

@philsturgeon philsturgeon commented Nov 15, 2017 •
edited
Loading

With upcoming changes to the Faraday adapter (#582), it's important to ensure it works for multiple versions of Faraday. I've been using Appraisal a bit for other gems I'm working on and it's really help out - catching a few unexpected issues.

I saw >= faraday 0.9.0 in the gemfile so I've included all versions since then. I've had to move the faraday dependency out of the Gemfile and into the gemspec to avoid it being specified twice with two different versions, as that'll trip up bundler. Let me know if that is a concern.

When v0.14.0 is out I'll come back and add that, as that's the one which drops the bundled typhoeus adapter.

This was referenced Nov 15, 2017
Open
Closed
@philsturgeon philsturgeon changed the title Use appraisal to ensure support for various versions of faraday. Use appraisal to ensure support for various versions of Faraday Nov 15, 2017
@philsturgeon philsturgeon changed the title Use appraisal to ensure support for various versions of Faraday Ensure support for various versions of Faraday Nov 15, 2017
philsturgeon
philsturgeon commented Nov 16, 2017
View reviewed changes
.travis.yml Outdated
fast_finish: true
allow_failures:
- rvm: ruby-head
- rvm: jruby-head
- rvm: ree
- rvm: 1.9
Copy link
Author

@philsturgeon philsturgeon Nov 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appraisal is generating these gemfiles but they're using short hash syntax instead of arrows meaning ruby < 2 fails. I've got Travis running the usual Gemfile and marked these appraisal gemfiles as allowed failures to get around this. Its not nice, but it works.

Phil Sturgeon added 4 commits November 15, 2017 20:51
@philsturgeon
Copy link
Author

The failures here are:

1.26s$ bundle exec rake

Randomized with seed 8336

An error occurred in a `before(:suite)` hook.

Failure/Error: res = ::Net::HTTP.get_response("localhost", '/__identify__', port)

Errno::EADDRNOTAVAIL:

  Cannot assign requested address - connect(2) for "localhost" port 3001

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `initialize'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `open'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:879:in `block in connect'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/timeout.rb:73:in `timeout'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:878:in `connect'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:863:in `do_start'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:852:in `start'

# /home/travis/.rvm/rubies/ruby-2.2.7/lib/ruby/2.2.0/net/http.rb:473:in `get_response'

# ./spec/support/localhost_server.rb:50:in `booted?'

# ./spec/support/localhost_server.rb:30:in `block in initialize'

# ./spec/support/localhost_server.rb:88:in `wait_until'

# ./spec/support/localhost_server.rb:30:in `initialize'

# ./spec/spec_helper.rb:15:in `new'

# ./spec/spec_helper.rb:15:in `block (2 levels) in <top (required)>'

Not sure what to do about this. Doesn't seem related to my changes.

@gguerini
Copy link

Hello, Faraday v0.14.0 was released on Jan 19th. Do you still plan on updating this pr?

@philsturgeon
Copy link
Author

@gguerini I wasn't sure how much point there was? I never heard back from anyone about the other issues failing the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philsturgeon @gguerini