Merge pull request dresden-elektronik#7475 from SwoopX/optimize_danfoss

DDF internal optimizations for Danfoss Ally and derivatives
traschke · Dec 20, 2023 · 749015f · 749015f
2 parents d2bffef + 0623344
commit 749015f
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/devices/danfoss/danfoss_windowopen_state.js b/devices/danfoss/danfoss_windowopen_state.js
@@ -1,17 +1,17 @@
 switch (Attr.val) {
     case 0:
-        Item.val = "Quarantine";
+        Item.val = "quarantine";
         break;
     case 1:
-        Item.val = "Closed";
+        Item.val = "closed";
         break;
     case 2:
-        Item.val = "Hold";
+        Item.val = "hold";
         break;
     case 3:
-        Item.val = "Open";
+        Item.val = "open";
         break;
     case 4:
-        Item.val = "Open (external), closed (internal)";
+        Item.val = "open (external), closed (internal)";
         break;
 }
diff --git a/devices/danfoss/etrv0100_thermostat.json b/devices/danfoss/etrv0100_thermostat.json
@@ -169,7 +169,15 @@
         },
         {
           "name": "config/heatsetpoint",
-          "refresh.interval": 3660
+          "refresh.interval": 3660,
+          "write": {
+            "fn": "zcl:cmd",
+            "ep": "0x01",
+            "cl": "0x0201",
+            "cmd": "0x40",
+            "eval": "'01' + ('00' + Item.val.toString(16)).slice(-2) + ('00' + Item.val.toString(16)).slice(-4,-2);",
+            "mf": "0x1246"
+          }
         },
         {
           "name": "config/loadbalancing",
@@ -375,9 +383,9 @@
             "at": "0x4000",
             "cl": "0x0B05",
             "ep": 1,
-            "eval": "Item.val = Attr.val;",
             "fn": "zcl:attr",
-            "mf": "0x1246"
+            "mf": "0x1246",
+            "script": "danfoss_errorcode.js"
           },
           "read": {
             "at": "0x4000",