-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B 21975 #14510
base: main
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as INT
B-21975
INT PR
Summary
This backlog was made to change a certain move history log that triggers when an update to an MTOShipment automatically updates an entitlement database table entry for the Max Billable Weight of that move. Previously, this was being labeled as "Updated allowance" and "Allowed weight", when in reality the allowance amount is not being updated, just the Max Billable Weight. As a result, the labels will be updated to read "Updated shipment" and "Max billable weight", respectively. The use case that uncovered this was when a prime updated the estimated weight for an HHG, increasing the max billable weight. This is the use case we will use for testing.
This backlog accomplishes this by using the same formatter used in updateBillableWeight.jsx to change the allowed weight value to be parsed by the history log correctly as max billable weight instead. It also updates the event name to "Updated shipment" instead of "Updated allowance".
Additionally, this has led me to think that the file could be better named and organized. Instead of putting it under allowances, I've renamed the file to follow the business process order of operations (update mtoShipment -> update allowance) and moved it under the updateMTOShipment directory instead. I think this meshes more nicely with the process it is trying to capture.
Verification Steps for the Author
These are to be checked by the author.
Verification Steps for Reviewers
These are to be checked by a reviewer.
How to test
Frontend
officeApp
class or custommin-width
styling is used to hide any states the would not be visible to the user.Screenshots
ANDI is passing as this only changes content of existing components