-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service failover option on Kubernetes CRD #11312
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
Signed-off-by: Jedrzej Kotkowski <jedrzejk143@gmail.com>
This is more of a proof of concept implementation (no tests included or documentation is currently included) than anything and I'd mostly like to get some feedback on how we can proceed with this, if at all.
If I could get some input on this or any other related feedback before I would be grateful. |
Hello @jjsiv and thanks for your contribution, We have reviewed the pull request and would like to share our concerns. Kubernetes (k8s) already includes a built-in health-check mechanism that manages service endpoints by adding or removing them based on pod readiness. Given this functionality, we believe extending the health-check mechanism to all service types is unnecessary. The health-check feature was originally introduced specifically for ExternalName services, as Kubernetes does not provide a native health-check mechanism for them. We would like to leverage Kubernetes health-check information to design the Failover service. At first glance, we have identified two potential approaches.
Personally, I would vote for the first option, as it ensures that the health-check intelligence is not duplicated in the Kubernetes CRD provider. Does it make sense? wdyt? |
Thanks for your feedback @kevinpollet. I agree, to rely on built-in Kubernetes mechanisms would be ideal and the first approach sounds good. I will see what I can come up with. |
Hello @jjsiv, Have you made any progress on the subject? If you want we can move forward on it and push some commits to your pull request or open a new one. |
What does this PR do?
This is a basic implementation of service failover feature on Kubernetes CRD provider.
Motivation
Currently failover is only configurable on the file provider. I've created an issue last year and there's been some interest in having this option also available on the Kubernetes provider #9919.
More
Additional Notes