Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adb-connect, adb-pair, adb-disconnect: add page #15250

Merged
merged 8 commits into from
Jan 5, 2025
Merged

adb-connect, adb-pair, adb-disconnect: add page #15250

merged 8 commits into from
Jan 5, 2025

Conversation

Managor
Copy link
Collaborator

@Managor Managor commented Dec 20, 2024 •
edited by sebastiaanspeck
Loading

#13997

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Dec 20, 2024
@Managor
Copy link
Collaborator Author

Managor commented Dec 20, 2024 •
edited
Loading

adb is painful how it has tons of subcommands that do a singular thing.

@Managor Managor mentioned this pull request Dec 20, 2024
Open
83 tasks
@gutjuri
Copy link
Member

gutjuri commented Dec 20, 2024

I think that the example with adb disconnect belongs in the adb disconnect page

@Managor
Copy link
Collaborator Author

Managor commented Dec 20, 2024

I disagree. Scattered subcommands that relate to each other and do a singular thing should be grouped together for easy access. There is no variation for how adb disconnect is used so having it be on its own page would be useless.

@gutjuri
Copy link
Member

gutjuri commented Dec 21, 2024

But adb connect is clearly not an alias for adb disconnect, which the page for adb disconnect currently suggests.

@Managor
Copy link
Collaborator Author

Managor commented Dec 21, 2024

That's true. I've been thinking if we could use a some other format for when a command has been moved.

Managor
Managor commented Dec 22, 2024
View reviewed changes
pages/common/adb-pair.md Outdated Show resolved Hide resolved
spageektti
spageektti reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@spageektti spageektti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your contribution. I wish a wonderful christmas time!

pages/common/adb-connect.md Outdated Show resolved Hide resolved
sebastiaanspeck
sebastiaanspeck requested changes Dec 31, 2024
View reviewed changes
pages/common/adb-connect.md Outdated Show resolved Hide resolved
pages/common/adb-pair.md Outdated Show resolved Hide resolved
Managor and others added 2 commits December 31, 2024 06:53
@Managor @sebastiaanspeck
Update pages/common/adb-connect.md
5457bbc 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@Managor @sebastiaanspeck
Update pages/common/adb-pair.md
e71adf3 
Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>
@sebastiaanspeck sebastiaanspeck merged commit 150f710 into tldr-pages:main Jan 5, 2025
4 checks passed
@Managor Managor deleted the adb-connect branch January 8, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spageektti spageektti spageektti left review comments

@gutjuri gutjuri gutjuri approved these changes

@sebastiaanspeck sebastiaanspeck sebastiaanspeck approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Managor @gutjuri @sebastiaanspeck @spageektti