Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: add page #15235

Merged
merged 3 commits into from
Dec 20, 2024
Merged

v: add page #15235

merged 3 commits into from
Dec 20, 2024

Conversation

dy-tea
Copy link
Contributor

@dy-tea dy-tea commented Dec 19, 2024 •
edited
Loading

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The page(s) follow the style guide.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):
    V 0.4.8 9acf058

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Dec 19, 2024
gutjuri
gutjuri reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have two suggestions.

pages/common/v.md Outdated Show resolved Hide resolved
pages/common/v.md Outdated Show resolved Hide resolved
dy-tea and others added 2 commits December 19, 2024 23:26
@dy-tea @gutjuri
Update v.md
73958d0 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
@dy-tea @gutjuri
Update v.md
0866a51 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
gutjuri
gutjuri approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

kbdharun
kbdharun approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@kbdharun kbdharun merged commit 9ac5a70 into tldr-pages:main Dec 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbdharun kbdharun kbdharun approved these changes

@gutjuri gutjuri gutjuri approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dy-tea @gutjuri @kbdharun