Add resource instance variables and audit log sample #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goosys
force-pushed
the
resource-instance-variables
branch
from
5cb4851 to
e77fb39
Compare
goosys
force-pushed
the
resource-instance-variables
branch
from
e77fb39 to
7d6f2c4
Compare
| @@ -9,6 +9,7 @@ def index | |||
| resources = apply_collection_includes(resources) | |||
| resources = order.apply(resources) | |||
| resources = paginate_resources(resources) | |||
| @resources = resources | |||
There was a problem hiding this comment.
This should be available through the locals (see lines 14-19). What use case do you have where that's not enough?
There was a problem hiding this comment.
For consistency. Since I made @requested_resource and @new_resource as instance variables, I made it so that @resources can also be referenced from instance variables.
|
I'm ok with this, but I think it should be consistent and always be Thoughts, @nickcharlton? |
|
Ah yeah, I see. Yeah, consistency is important here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made changes so that instance variables are stored in both the index and create actions, in order to capture controller operation logs and perform other post-processing tasks.
Please review.