use hypot for magnitude to reduce over/underflow

thehappycheese · Aug 8, 2023 · c03a1f9 · c03a1f9
1 parent 360d5f0
commit c03a1f9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/geo/src/algorithm/vector_ops.rs b/geo/src/algorithm/vector_ops.rs
@@ -132,7 +132,9 @@ where
     }
 
     fn magnitude(self) -> Self::Scalar {
-        (self.x * self.x + self.y * self.y).sqrt()
+        // Note uses cmath::hypot which avoids 'undue overflow and underflow'
+        // This also increases the range of values for which `.try_normalize()` works
+        Self::Scalar::hypot(self.x, self.y)
     }
 
     fn magnitude_squared(self) -> Self::Scalar {