Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Items menu sub items alphabetically #1023

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Sort Items menu sub items alphabetically #1023

merged 1 commit into from
Dec 16, 2024

Conversation

Razzmatazzz
Copy link
Member

Current items menu is randomly sorted:
image

This PR sorts that submenu alphabetically:
image

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner December 13, 2024 18:51
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Note: If you have a larger change and want to block deployments, you can run .lock --reason <reason> to lock all other deployments (remove with .unlock)

You can view the branch deploy usage guide for additional information

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production (branch: sort-items-menu)

You can watch the progress here 🔗

Details
{
  "type": "branch",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "timestamp": "2024-12-14T12:02:57.993Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/12329665864"
  },
  "git": {
    "branch": "sort-items-menu",
    "commit": "4f7c5d03ab5bef40307c5ed6d2ded0f130307e85",
    "verified": false
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false,
    "comment": {
      "created_at": "2024-12-14T12:02:39Z",
      "updated_at": "2024-12-14T12:02:39Z",
      "body": ".deploy",
      "html_url": "https://github.com/the-hideout/tarkov-dev/pull/1023#issuecomment-2543077108"
    }
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch sort-items-menu to production

Details
{
  "status": "success",
  "environment": {
    "name": "production",
    "url": "https://tarkov.dev"
  },
  "deployment": {
    "id": 2040485813,
    "timestamp": "2024-12-14T12:04:47.731Z",
    "logs": "https://github.com/the-hideout/tarkov-dev/actions/runs/12329665864",
    "duration": 110
  },
  "git": {
    "branch": "sort-items-menu",
    "commit": "4f7c5d03ab5bef40307c5ed6d2ded0f130307e85",
    "verified": false
  },
  "context": {
    "actor": "Razzmatazzz",
    "noop": false,
    "fork": false
  },
  "reviews": {
    "count": 0,
    "decision": "REVIEW_REQUIRED"
  },
  "parameters": {
    "raw": null,
    "parsed": null
  }
}

Environment URL: tarkov.dev

@GrantBirki GrantBirki merged commit e5dba3c into main Dec 16, 2024
2 checks passed
@GrantBirki GrantBirki deleted the sort-items-menu branch December 16, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants