Fix warning in nightly rust

``` warning: unused return value of `alloc::boxed::Box::<T>::from_raw` that must be used Warning: --> internal/core/properties.rs:382:9 | 382 | Box::from_raw(_self as *mut BindingHolder<B>); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: call `drop(from_raw(ptr))` if you intend to drop the `Box` ``` Just do what the note says
task-jp · Jul 18, 2022 · ced9504 · ced9504
1 parent dd5adeb
commit ced9504
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/helper_crates/vtable/macro/macro.rs b/helper_crates/vtable/macro/macro.rs
@@ -424,7 +424,7 @@ pub fn vtable(_attr: TokenStream, item: TokenStream) -> TokenStream {
                 vtable_ctor.push(quote!(#ident: {
                     #sig_extern {
                         unsafe {
-                            Box::from_raw((#self_call).0 as *mut _);
+                            ::core::mem::drop(Box::from_raw((#self_call).0 as *mut _));
                         }
                     }
                     #ident::<T>

diff --git a/internal/core/items/flickable.rs b/internal/core/items/flickable.rs
@@ -144,9 +144,7 @@ impl Default for FlickableDataBox {
 impl Drop for FlickableDataBox {
     fn drop(&mut self) {
         // Safety: the self.0 was constructed from a Box::leak in FlickableDataBox::default
-        unsafe {
-            Box::from_raw(self.0.as_ptr());
-        }
+        drop(unsafe { Box::from_raw(self.0.as_ptr()) });
     }
 }
 

diff --git a/internal/core/properties.rs b/internal/core/properties.rs
@@ -379,7 +379,7 @@ impl BindingHolder {
 fn alloc_binding_holder<B: BindingCallable + 'static>(binding: B) -> *mut BindingHolder {
     /// Safety: _self must be a pointer that comes from a `Box<BindingHolder<B>>::into_raw()`
     unsafe fn binding_drop<B>(_self: *mut BindingHolder) {
-        Box::from_raw(_self as *mut BindingHolder<B>);
+        drop(Box::from_raw(_self as *mut BindingHolder<B>));
     }
 
     /// Safety: _self must be a pointer to a `BindingHolder<B>`