Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notification): add service worker support for @ng-web-apis/notification #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(notification): add service worker support for @ng-web-apis/notification #218

wants to merge 1 commit into from

Conversation

nsbarsukov
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the new behaviour?

Partially solves #96

Add support for mobile devices

IOS:

@nsbarsukov nsbarsukov self-assigned this Oct 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 8540266):

https://ng-web-apis-common--pr218-notification-api-for-rg2goj9u.web.app

(expires Sat, 16 Dec 2023 11:25:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9d81cd8541a1a45fa12e730c551222bb3d5ceb9

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (7734a40) 88.84% compared to head (a611f17) 87.31%.
Report is 33 commits behind head on main.

❗ Current head a611f17 differs from pull request most recent head 8540266. Consider uploading reports for the commit 8540266 to get more accurate results

Files Patch % Lines
.../notification/src/services/notification.service.ts 30.43% 16 Missing ⚠️
...bs/notification/src/tokens/notification-factory.ts 30.00% 7 Missing ⚠️
libs/notification/src/utils/provide-sw-push.ts 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   88.84%   87.31%   -1.53%     
==========================================
  Files         204      208       +4     
  Lines        1210     1246      +36     
  Branches      130      134       +4     
==========================================
+ Hits         1075     1088      +13     
- Misses        109      132      +23     
  Partials       26       26
Flag Coverage Δ
audio 79.92% <ø> (ø)
canvas 95.97% <ø> (ø)
common 100.00% <ø> (ø)
geolocation 100.00% <ø> (ø)
intersection-observer 98.00% <ø> (ø)
midi 100.00% <ø> (ø)
mutation-observer 100.00% <ø> (ø)
notification 48.33% <32.55%> (-18.34%) ⬇️
payment-request 100.00% <ø> (ø)
permissions 78.78% <ø> (ø)
resize-observer 100.00% <ø> (ø)
speech 100.00% <ø> (ø)
storage 100.00% <ø> (ø)
summary 87.31% <32.55%> (-1.53%) ⬇️
universal 100.00% <ø> (ø)
view-transition 85.71% <ø> (ø)
workers 98.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsbarsukov nsbarsukov force-pushed the notification-api-for-mobiles branch from a065191 to c79b71d Compare November 7, 2023 07:18
@github-actions github-actions bot added the ready to merge ready label Nov 7, 2023
@nsbarsukov nsbarsukov removed the ready to merge ready label Nov 7, 2023
@splincode splincode force-pushed the notification-api-for-mobiles branch from a611f17 to c683182 Compare November 16, 2023 08:30
@nsbarsukov nsbarsukov force-pushed the notification-api-for-mobiles branch from c683182 to b16edfa Compare December 15, 2023 11:17
@nsbarsukov nsbarsukov force-pushed the notification-api-for-mobiles branch from b16edfa to 8540266 Compare December 15, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea left review comments

@splincode splincode splincode approved these changes

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

Assignees

@nsbarsukov nsbarsukov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsbarsukov @waterplea @splincode