Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shortcut support to open TabWrangler popup #494

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

xiio
Copy link
Contributor

@xiio xiio commented Dec 22, 2024

This PR introduces a keyboard shortcut feature that allows users to quickly open the TabWrangler popup without clicking the toolbar button.

@ssorallen
Copy link
Member

ssorallen commented Dec 23, 2024

Thank you for the pull request. Chrome already adds a shortcut for all extensions that opens the pop up (called "Activate the extension" in keyboard shortcuts). Have you tried that, or are you a Firefox user?

Screenshot 2024-12-23 at 9 35 42 AM

@xiio
Copy link
Contributor Author

xiio commented Dec 24, 2024

Hello @ssorallen!

Thank you for your reaction! I noticed that during test, but I'm Firefox user and unfortunately 🦊 is missing this feature by default… 🤷

Copy link
Member

@ssorallen ssorallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the FF-specific config into the Webpack config so it only appears in FF.

app/manifest.template.json Outdated Show resolved Hide resolved
@ssorallen
Copy link
Member

Thanks for the update, I tested in Firefox and it looks great.

@ssorallen ssorallen merged commit 30c4da6 into tabwrangler:main Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants