support for multiple synced paginators #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also the "container" variable used in the "observer" function of the pagination object, to wire up "container.on('event')" events that are triggered through normal use, such as the "go" event. This causes data to be rendered more than once depending on how many pagination instances are being used in the DOM. So to mitigate this i declared "var eventContainer = $(container[0]);" to get only the first instance and replace every wire that uses container in the function with it so it only fires once. E.g. "eventContainer.on(eventPrefix + 'next', function(event, done) { This starts around line 646. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just changed 2 lines to the pagination.js source:
line 108 becomes:$(".paginationjs").length > 0 ? $ (".paginationjs") : $('
');var el =
line 643 becomes:
var el = $(".paginationjs");
with those changes, it's possible to have multiple paginators on the page by setting multiple DIVs with a given class in the HTML and then using the jQuery locator for the class in the script.
example:
HTML:
JS:
$('#pagination-container').pagination({
dataSource: [1, 2, 3, 4, 5, 6, 7, ... , 195],
callback: function(data, pagination) {
// template method of yourself
var html = template(data);
$('#data-container').html(html);
}
})